Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purple-matrix: 2016-07-11 -> 2018-08-02 #45974

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

symphorien
Copy link
Member

@symphorien symphorien commented Sep 3, 2018

This also fixes the build.

Motivation for this change

The build was broken. This probably should be backported to 18.09. Should I open another PR for this ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I tested the plugin with pidgin, it works, except that icons seem to be ignored for some reason.

This also fixes the build.
@symphorien
Copy link
Member Author

cc #45960

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 3, 2018
vcunat added a commit that referenced this pull request Sep 3, 2018
@vcunat
Copy link
Member

vcunat commented Sep 3, 2018

Backported, too.

@vcunat vcunat merged commit 7de2b62 into NixOS:master Sep 3, 2018
@symphorien symphorien deleted the purple-matrix branch March 21, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants