Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systrayhelper: init at 0.0.3 #45997

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Sep 3, 2018

Motivation for this change

systrayhelper offers a stdio json interface to create menu-items and send click events back over stdout.
It is used by some other applications I'd like to introduce to nixpkgs.

Things done
  • Tested using nix.useSandbox on my two nixos machines
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Questions:

  • Is there a way to get the current date/time as a string?

See default.nix:19, I'd like to do something like -X main.date=$(date +%F)

  • Is meta.platform just informational?

I wasn't sure about restricting it. This should built on linux, darwin and possibly others where the libraries are available.

cryptix added a commit to ssbc/systrayhelper that referenced this pull request Sep 3, 2018
See NixOS/nixpkgs#45997

also, you can built with local changes using this invocation:

with import <nixpkgs> { };
systrayhelper.overrideDerivation (drv: { src = ./myCheckout; })
@symphorien
Copy link
Member

For the date, you should use the date of the corresponding commit for example to keep the derivation deterministic. Otherwise, we would have to rebuild it every time.

cryptix added a commit to talenet/talenet that referenced this pull request Sep 5, 2018
ps: this also uses scuttle-shell, which depends on systrayhelper
NixOS/nixpkgs#45997

hit a bug using node2nix -8 which is why i'm trying 6 right now:
svanderburg/node2nix#106 (comment)
cryptix added a commit to cryptix/nixpkgs that referenced this pull request Sep 11, 2018
@cryptix cryptix changed the title systrayhelper: init at 0.0.2 systrayhelper: init at 0.0.3 Sep 17, 2018
@cryptix
Copy link
Contributor Author

cryptix commented Sep 17, 2018

I updated this to 0.0.3 and squashed everything into one commit based on the master of today.

offers a stdio json interface to create menu-items.
and send click events back over stdout.
cryptix added a commit to talenet/talenet that referenced this pull request Oct 4, 2018
ps: this also uses scuttle-shell, which depends on systrayhelper
NixOS/nixpkgs#45997

hit a bug using node2nix -8 which is why i'm trying 6 right now:
svanderburg/node2nix#106 (comment)
@matthewbauer
Copy link
Member

@GrahamcOfBorg build systrayhelper

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systrayhelper

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h41yfbb1j23a1mhnd2hfcbndapkpx75a-systrayhelper-0.0.3-bin
shrinking /nix/store/h41yfbb1j23a1mhnd2hfcbndapkpx75a-systrayhelper-0.0.3-bin/bin/systrayhelper
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h41yfbb1j23a1mhnd2hfcbndapkpx75a-systrayhelper-0.0.3-bin/bin
patching script interpreter paths in /nix/store/h41yfbb1j23a1mhnd2hfcbndapkpx75a-systrayhelper-0.0.3-bin
checking for references to /build in /nix/store/h41yfbb1j23a1mhnd2hfcbndapkpx75a-systrayhelper-0.0.3-bin...
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
/nix/store/h41yfbb1j23a1mhnd2hfcbndapkpx75a-systrayhelper-0.0.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: systrayhelper

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rr1lxwdpw3gnkgkwzpnqr2csg4n9610l-systrayhelper-0.0.3-bin
shrinking /nix/store/rr1lxwdpw3gnkgkwzpnqr2csg4n9610l-systrayhelper-0.0.3-bin/bin/systrayhelper
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rr1lxwdpw3gnkgkwzpnqr2csg4n9610l-systrayhelper-0.0.3-bin/bin
patching script interpreter paths in /nix/store/rr1lxwdpw3gnkgkwzpnqr2csg4n9610l-systrayhelper-0.0.3-bin
checking for references to /build in /nix/store/rr1lxwdpw3gnkgkwzpnqr2csg4n9610l-systrayhelper-0.0.3-bin...
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
/nix/store/rr1lxwdpw3gnkgkwzpnqr2csg4n9610l-systrayhelper-0.0.3-bin

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: systrayhelper

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@matthewbauer matthewbauer merged commit 3cb179a into NixOS:master Oct 8, 2018
@cryptix cryptix deleted the add/systrayhelper branch October 8, 2018 22:27
cryptix added a commit to talenet/talenet that referenced this pull request Oct 18, 2018
ps: this also uses scuttle-shell, which depends on systrayhelper
NixOS/nixpkgs#45997

hit a bug using node2nix -8 which is why i'm trying 6 right now:
svanderburg/node2nix#106 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants