-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go_1_11: Allow only one of GOARM={5,6,7} #46031
Conversation
@GrahamcOfBorg build go_1_11 |
Failure on x86_64-darwin (full log) Attempted: go_1_11 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: go_1_11 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: go_1_11 Partial log (click to expand)
|
5acd170
to
ad770fa
Compare
@GrahamcOfBorg build go_1_11 |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: go_1_11 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: go_1_11 Partial log (click to expand)
|
ad770fa
to
17b6efa
Compare
@GrahamcOfBorg build go_1_11 |
Success on x86_64-linux (full log) Attempted: go_1_11 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: go_1_11 Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: go_1_11 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: go_1_11 Partial log (click to expand)
|
/cc ZHF #45962 This should fix the massive go breakage on aarch. |
Success on x86_64-darwin (full log) Attempted: go_1_11 Partial log (click to expand)
|
Motivation for this change
According to https://github.com/golang/go/wiki/GoArm GOARM is allowed to be just one of 5,6 or 7.
It is recommended to aways set it in order to support cross compilation.
Fixes go and packages broken by the upgrade to go 1.11 on aarch
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)