Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#45960
This upgrades yabause to 0.9.15, disregarding the comment about how "0.9.5 only works with OpenGL 3.2 or later". This is because using the existing fixes for 5.11 is easier with a fresher codebase. The fix for Qt 5.11 upgrade is adapted from upstream, as noted in a comment.
cc @yegortimoshenko about the version upgrade. I'm not sure nixpkgs should mediate versions of the software provided by default.
It'll need cherry-picking to release-18.09
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)#44047 stops me from testing this on my still 18.03 box :/. Additionally, I don't have files to run to test it working.