-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc*: fix libgomp (OpenMP) to work w/musl, don't build DSO using initial-exec #47309
Conversation
Only apply w/musl since while it's wrong everywhere it apparently hasn't broken things entirely w/glibc so keep things as they were. Patch regenerated from original so that it applies which isn't saying much since it's simple :). Source: https://patchwork.ozlabs.org/patch/154298/ IRC chat on #musl with Rich and others endorses this, at least at the conceptual level of no shared library should be using initial-exec TLS. Fixes various uses of libgomp that previously crashed (before 1.1.20) or encounter errors (post-1.1.20), such as pythonPackages.cython .
cc @nh2 -- this should fix the Cython problem you encountered over on nh2/static-haskell-nix#6 (comment) . If it doesn't then one of the minor updates is needed first, but I'll have the answer to that in a few minutes-- cython tests take a long time :3. |
Update: yep cython "still" works with these fixes--as it should :). If you use allvm.cachix.org, path is: Anyway hopefully will be on a proper nixpkgs branch soon! |
Success on x86_64-darwin (full log) Attempted: gcc, gcc7, openblas Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: gcc, gcc7, openblas Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: gcc, gcc7, openblas Partial log (click to expand)
|
Post-merge review/comments welcome as always! :) |
See commits for details and links.
When testing this[1] it fixed enabling OpenMP support in openblas and
in particular fixed Cython which was failing tests due to dlopen'ing borked libgomp.so
[1] on top of (minor) updates to cython/openblas/numpy not yet merged in our tree,
but I believe in PR's already
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)