pythonPackages.gyp: add Xcode 10 support #48737
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Attempting to use it with Xcode 10 installed results in this:
The fix is updating the regex to handle version numbers with multiple digits.
This is fixed in the nodejs fork of gyp (nodejs/node-gyp#1454) but it's not fixed upstream, even on latest master. Given that upstream gyp is pretty much abandoned since the chromium project switched to GN, it might be worth switching to use the nodejs fork.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)