pyo3-pack: 0.3.8 -> 0.5.0

[robertodr]

Motivation for this change

Update pyo3-pack to its latest version.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[veprbl]

cc @danieldk

[danieldk]

Thanks for the update! Currently testing against our project, will report back within the hour or so...

[danieldk]

Unfortunately, this change does not work on (my) darwin (macOS 10.14.3):

$ pyo3-pack 
dyld: Library not loaded: @rpath/libproc_macro-d4266636a11dd50a.dylib
  Referenced from: /nix/store/r6zm9vv1lygq3faw35mahxrcs7l3nxl6-pyo3-pack-0.5.0/bin/pyo3-pack
  Reason: image not found
Abort trap: 6

It seems that it tries to dynamically link the dependent crates:

$ otool -L `which pyo3-pack`
/nix/store/r6zm9vv1lygq3faw35mahxrcs7l3nxl6-pyo3-pack-0.5.0/bin/pyo3-pack:
	@rpath/libproc_macro-d4266636a11dd50a.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/libsyntax-8e769437e3648ad4.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/librustc_target-7ff8eedff7ca3637.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/librustc_errors-5a0caaf966aacf01.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/libsyntax_pos-cdcb6ed983a20bc1.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/libarena-b7aab6b6a5bea115.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/librustc_data_structures-1084c8bd030620f2.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/librustc_cratesio_shim-d3f5d7e303f42eb8.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/libgraphviz-83eb64cca0343abc.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/libserialize-0bd1112a715df097.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/libstd-6ee24e3247ed8c3c.dylib (compatibility version 0.0.0, current version 0.0.0)
	/System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 58286.240.4)
	/nix/store/0bi9n2vchd9ddf8xnris9rsfaflf18ml-Libsystem-osx-10.11.6/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)
	/nix/store/0bi9n2vchd9ddf8xnris9rsfaflf18ml-Libsystem-osx-10.11.6/lib/libresolv.9.dylib (compatibility version 1.0.0, current version 1.0.0)

The version that is currently in nixpkgs still seems to build and work without problems.

[robertodr]

I am afraid I don't know how to debug that failure on Darwin. The diff between v0.3.8 and v0.5.0 doesn't show anything in particular regarding dynamically linking dependent crates.

[konstin]

That's a bug in older versions of rustc. The latest stable release fixes that. (Full details: mozilla/cbindgen#203)

[veprbl]

@GrahamcOfBorg build pyo3-pack

[veprbl]

We are currently on rustc 1.32.0, so, I guess, we are waiting for 1.33.0?

[veprbl]

@GrahamcOfBorg build pyo3-pack

[veprbl]

Let's give it another spin:
@GrahamcOfBorg build pyo3-pack

[veprbl]

Builds locally on darwin