Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.rabbitpy: Fix build #56853

Merged
merged 1 commit into from
Mar 17, 2019
Merged

pythonPackages.rabbitpy: Fix build #56853

merged 1 commit into from
Mar 17, 2019

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes pythonPackages.rabbitpy. Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested a review from FRidh as a code owner March 4, 2019 22:09
@worldofpeace
Copy link
Contributor

ping @knedlsepp

worldofpeace
worldofpeace approved these changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine now with tests passing 👍

@worldofpeace worldofpeace merged commit 2016b37 into NixOS:master Mar 17, 2019
@worldofpeace
Copy link
Contributor

Backported in 0e6990d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knedlsepp @worldofpeace @GrahamcOfBorg