Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autossh: fix for cross compilation #57825

Merged
merged 1 commit into from
Mar 24, 2019
Merged

autossh: fix for cross compilation #57825

merged 1 commit into from
Mar 24, 2019

Conversation

illegalprime
Copy link
Member

Motivation for this change

Fixes for cross compilation in autossh, the preConfigure phase is to fix a undefined reference to rpl_malloc'` error that comes up when cross-compiling.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from pSub March 17, 2019 19:11
@roberth roberth mentioned this pull request Mar 17, 2019
Merged
10 tasks
@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Mar 24, 2019
@Mic92 Mic92 merged commit 6158b9e into NixOS:master Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth left review comments

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@illegalprime @roberth @Mic92 @veprbl @GrahamcOfBorg