Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: fix aarch64 build #58589

Merged
merged 1 commit into from
Apr 7, 2019
Merged

openblas: fix aarch64 build #58589

merged 1 commit into from
Apr 7, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Mar 30, 2019 •
edited
Loading

Motivation for this change

Fixes #56949

Attempt to fix the openblas breakage on aarch64
#56216

If we are not cross compiling then openblas expects:

  • on x86_64 NO_BINARY_MODE=
  • on aarch64 NO_BINARY_MODE=0

using the toString to translate the value for NO_BINARY_MODE is wrong here
since mkMakeFlagValue is supposed to translate bools to string in the right way.

Needs backport to 19.03

CC @dtzWill

See also: ZHF 19.03, #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa added the 2.status: work-in-progress This PR isn't done label Mar 30, 2019
@markuskowa
Copy link
Member Author

markuskowa commented Mar 30, 2019 •
edited
Loading

@GrahamcOfBorg build openblas
@GrahamcOfBorg build arpack

@markuskowa
Copy link
Member Author

This fix is really ugly but it works now on arm and x86. Any suggestions?

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 501+ 10.rebuild-linux: 501-1000 labels Mar 30, 2019
@markuskowa markuskowa changed the title [WIP] openblas: fix aarch64 build openblas: fix aarch64 build Mar 31, 2019
@markuskowa markuskowa removed the 2.status: work-in-progress This PR isn't done label Mar 31, 2019
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request Apr 7, 2019
@vcunat
Merge NixOS#58589: openblas: fix aarch64 build
e1f5559
@xeji xeji merged commit fa28a83 into NixOS:master Apr 7, 2019
vcunat added a commit that referenced this pull request Apr 7, 2019
@vcunat
Merge #58589: openblas: fix aarch64 build
e2c99ce 
(cherry picked from commit e1f5559)
@markuskowa markuskowa deleted the fix-openblas branch April 7, 2019 15:07
@aanderse aanderse mentioned this pull request May 12, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@FRidh FRidh Awaiting requested review from FRidh

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openblas: build broken on aarch64 (master & release 19.03)
4 participants
@markuskowa @vcunat @GrahamcOfBorg @xeji