Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin: 10.2.2 -> 10.3.0 #59952

Merged
merged 1 commit into from
Apr 22, 2019
Merged

jellyfin: 10.2.2 -> 10.3.0 #59952

merged 1 commit into from
Apr 22, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Apr 21, 2019 •
edited
Loading

Motivation for this change

Tested on a 19.03 server by cherry-picking the commits

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre nyanloutre requested a review from infinisil as a code owner April 21, 2019 10:49
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 21, 2019
@aanderse
Copy link
Member

@nyanloutre #59465

@nyanloutre
Copy link
Member Author

@aanderse oh I didn't see it

@aanderse
Copy link
Member

@aanderse oh I didn't see it

You two should collaborate 😄 Maybe you want to write a NixOS test for the new module?

@nyanloutre
Copy link
Member Author

I will remove the module from this PR as the update is still relevant

@nyanloutre nyanloutre changed the title jellyfin: 10.2.2 -> 10.3.0 and module init jellyfin: 10.2.2 -> 10.3.0 Apr 21, 2019
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 21, 2019
@nyanloutre
Copy link
Member Author

@GrahamcOfBorg build jellyfin

aanderse
aanderse approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jellyfin/jellyfin/releases/tag/v10.3.0

Worth noting this update is not backwards compatible and requires user intervention... but such can be expected from a fork so early in its life.

LGTM 👍

@aanderse aanderse merged commit b23f87e into NixOS:master Apr 22, 2019
@nyanloutre nyanloutre deleted the jellyfin-update branch April 23, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyanloutre @aanderse @GrahamcOfBorg