Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peco: fix incorrect termbox-go rev in deps.nix #60281

Merged
merged 1 commit into from
Apr 29, 2019
Merged

peco: fix incorrect termbox-go rev in deps.nix #60281

merged 1 commit into from
Apr 29, 2019

Conversation

samdoshi
Copy link
Contributor

Peco 0.5.3 included an update to the termbox-go dependency to fix a bug, this change did not make it into deps.nix.

See:

Motivation for this change

Peco 0.5.3 is currently broken for me on 19.03 due to garbled text, see the linked issues above for an example.

Also see the glide.lock for Peco 0.5.3 to see the mismatch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samdoshi
peco: fix incorrect termbox-go rev in deps.nix
ea0c4c9 
Peco 0.5.3 included an update to the termbox-go dependency to fix a bug,
this change did not make it into deps.nix.

See:

 - peco/peco#446
 - peco/peco#447
 - nsf/termbox-go#185
tomberek
tomberek approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also builds/runs/functions on Ubuntu

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@timokau
Copy link
Member

timokau commented Apr 29, 2019

Thanks for the fix and welcome to the community :)

@timokau timokau merged commit 3be0cc4 into NixOS:master Apr 29, 2019
@samdoshi samdoshi deleted the peco-deps branch May 1, 2019 10:33
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samdoshi @nixos-discourse @timokau @tomberek @Janik-Haag