Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.macropy: init at 1.10b2 #61094

Merged
merged 2 commits into from
May 20, 2019
Merged

pythonPackages.macropy: init at 1.10b2 #61094

merged 2 commits into from
May 20, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented May 7, 2019

Motivation for this change

Use macropy to abuse python syntax

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner May 7, 2019 16:28
@costrouc costrouc force-pushed the python-macropy-init branch from bf19c27 to 6cc0f50 Compare May 7, 2019 16:31
@costrouc
Copy link
Member Author

costrouc commented May 7, 2019

Result of nix-review pr 61094 1

1 package were build:
  • python37Packages.macropy

@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 7, 2019
@worldofpeace
Copy link
Contributor

Did the author/s purposely not publish this release to PyPI?
Noticing on PyPI that the last release there is v1.0.3.

@costrouc
Copy link
Member Author

costrouc commented May 7, 2019

I am packaging a newer version because the older releases do not have python 3 support and the installation is more complicated.

@worldofpeace
Copy link
Contributor

I am packaging a newer version because the older releases do not have python 3 support and the installation is more complicated.

Yep totally get that. (python2 bye bye)
But I'm just thinking that this detail isn't outwardly apparent, are these pre-releases?
Pretty sure they could be publishing those.

This looks perfect, but could you open an issue on their github asking about this?
And from there just drop the link in the expression so if it gets clarified it's documented.

@costrouc costrouc force-pushed the python-macropy-init branch from 6cc0f50 to dda82ef Compare May 8, 2019 14:51
@costrouc costrouc mentioned this pull request May 8, 2019
Open
@costrouc
Copy link
Member Author

costrouc commented May 8, 2019

@worldofpeace I created an issue on macropy for a stable python 3 release. Also I have added support for extras. nix review passes

Result of nix-review pr 61094 1

3 package were build:
  • python27Packages.pyxl3
  • python37Packages.macropy
  • python37Packages.pyxl3

worldofpeace
worldofpeace suggested changes May 8, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last little comments, once resolved I'll merge promptly.

pkgs/development/python-modules/macropy/default.nix Show resolved Hide resolved
pkgs/development/python-modules/macropy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyxl3/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyxl3/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyxl3/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyxl3/default.nix Outdated Show resolved Hide resolved
@costrouc costrouc force-pushed the python-macropy-init branch from dda82ef to 184c9df Compare May 20, 2019 13:00
@costrouc
Copy link
Member Author

@worldofpeace your requested changes have been made and passes nix-review

Result of nix-review pr 61094 1

2 package were build:
  • python37Packages.macropy
  • python37Packages.pyxl3

worldofpeace
worldofpeace approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent ✨

@worldofpeace worldofpeace merged commit 272bec5 into NixOS:master May 20, 2019
@worldofpeace
Copy link
Contributor

Thanks @costrouc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@costrouc @worldofpeace