Skip to content

pythonPackages.serverlessrepo: fix pyyaml override#62051

Merged
Ma27 merged 2 commits intoNixOS:masterfrom
dhl:serverlessrepo-fix-pyyaml
May 25, 2019
Merged

pythonPackages.serverlessrepo: fix pyyaml override#62051
Ma27 merged 2 commits intoNixOS:masterfrom
dhl:serverlessrepo-fix-pyyaml

Conversation

@dhl
Copy link
Member

@dhl dhl commented May 25, 2019

Motivation for this change

The previous PR #62011 botched pythonPackages.serverlessrepo by overriding PyYAML, even though serverlessrepo is a python module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dhl dhl requested a review from FRidh as a code owner May 25, 2019 12:54
@dhl dhl mentioned this pull request May 25, 2019
Merged
10 tasks
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 25, 2019
@Ma27
Copy link
Member

Ma27 commented May 25, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 09e2189 into NixOS:master May 25, 2019
@Ma27
Copy link
Member

Ma27 commented May 25, 2019

@dhl thanks!

@dhl
Copy link
Member Author

dhl commented May 25, 2019

Thanks again @Ma27. Very sorry about the previous PR.

@dhl dhl deleted the serverlessrepo-fix-pyyaml branch May 25, 2019 14:21
@FRidh
Copy link
Member

FRidh commented May 25, 2019

@dhl thanks and no problem; it's impossible to know every detail in Nixpkgs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhl @Ma27 @FRidh