Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtrap: Added missing dependencies #63994

Closed
wants to merge 2 commits into from
Closed

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Jul 1, 2019

Fixed the failing build of xtrap by adding missing dependencies. #56826

I do want to note that without depending on utilmacros, it will still build even though it complains it can't find it during the configure phase. The configure.ac mentions that it is required so I added it as a dependency.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ahiaao ahiaao changed the title xtrap: Add missing dependencies xtrap: Added missing dependencies Jul 1, 2019
@ahiaao
Copy link
Contributor Author

ahiaao commented Sep 10, 2019

Looks like someone fixed this issue a month later and there fix made it into master.
#65806

@ahiaao ahiaao closed this Sep 10, 2019
@ahiaao ahiaao deleted the fix/xtrap branch November 17, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant