perl: fix errant references when cross-compiling #65761
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Cross-compiled Perl ends up with references to its source tarball and build
coreutils
.Things done
The source tarball reference was a bit perplexing, but it turns out that Perl's build system uses the
src
environment variable, and writes its value into a header in the output. For native builds, some part of the config ends up of overwriting this variable, but this does not happen when cross-compiling.The
coreutils
reference was simply an assumption that the correct binary would be inPATH
.sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @edolstra