-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix-synapse: 1.2.1 -> 1.3.0 #66677
Conversation
Off-TopicI created a channel for the coordination / discussion of the matrix subsystem. |
How about changing the nixos module as well to make use of this? |
@ofborg build nixosTests.matrix-synapse |
You mean |
You mean Type=notify in the systemd unit?
Yep.
Is there anything more to do?
Don't think so.
|
Starting with 1.3.0, matrix-synapse supports notifying systemd. Relevant PR: matrix-org/synapse#5732
I changed the module as well. |
Seems like v1.3.1 dropped the the sdnotify dependency again. Seems like they implemented the functionality manually. |
I will update the branch asap. |
replaced by #66814 |
Motivation for this change
https://github.com/matrix-org/synapse/releases/tag/v1.3.0
Performance improvements mostly. Added sd_notify due to matrix-org/synapse#5732
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @pacien @Ekleog