Skip to content

aws-sam-cli: update requests dependency to 2.22.0#67267

Merged
grahamc merged 1 commit intoNixOS:masterfrom
scoates:update-aws-sam-cli
Aug 22, 2019
Merged

aws-sam-cli: update requests dependency to 2.22.0#67267
grahamc merged 1 commit intoNixOS:masterfrom
scoates:update-aws-sam-cli

Conversation

@scoates
Copy link
Contributor

@scoates scoates commented Aug 22, 2019

Motivation for this change

pythonPackages.requests was updated to v2.22.0 on July 21.

aws-sam-cli is hard-coded to set the requests version to 2.21.0, so aws-sam-cli currently fails to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andreabedini @dhl

@grahamc
Copy link
Member

grahamc commented Aug 22, 2019

@GrahamcOfBorg build aws-sam-cli

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 22, 2019
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

[2 built, 15 copied (4.4 MiB), 1.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67267
1 package were build:
aws-sam-cli

@grahamc grahamc merged commit 7305796 into NixOS:master Aug 22, 2019
@scoates scoates deleted the update-aws-sam-cli branch August 22, 2019 18:11
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants