-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gimp: 2.10.38 → 3.0.0-RC2 #67576
base: master
Are you sure you want to change the base?
gimp: 2.10.38 → 3.0.0-RC2 #67576
Conversation
The gjs failure will require #72805 |
]; | ||
|
||
buildInputs = [ | ||
python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this won't work if it ends up in a shebang for darwin (because wrappers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bah. Hoping for C wrappers before GIMP 3 is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good news! makeBinaryWrapper
is a thing now: #124556
715ab15
to
f52c409
Compare
c750da1
to
359513f
Compare
@GrahamcOfBorg eval |
d83954d
to
65d90f9
Compare
Is this PR abandoned? |
i don't expect so, it's more that it probably should be in a different format while gnu imp 3.x is still in dev also btw there's a bug where the meson build type is wrong so there's no optimization and the performance sucks |
I update it as time permits. Just bumped it to 3.0.0-RC1.
How do you determine that? We use the Edit: Yeah, default-enabled |
Co-Authored-By: Linus Heckemann <git@sphalerite.org>
https://www.gimp.org/news/2022/08/27/gimp-2-99-12-released/ GNOME/gimp@256b2d9...a791151 Introduces `gimp-script-fu-interpreter-3.0` as interpreter invoked by shebang of some plug-ins. Let’s ensure it is on `PATH`.
GNOME/gimp@ad7a2e5...GIMP_3_0_0_RC1 - gtk-mac-integration dependency removed https://gitlab.gnome.org/GNOME/gimp/-/commit/df4ed9c1ec85117747e41e4540cb75b02284bdbe - Python plug-in mandatory https://gitlab.gnome.org/GNOME/gimp/-/commit/93cc81281cd12c55139f483d65629be9c31e798d - Only Lua 5.1 is supported https://gitlab.gnome.org/GNOME/gimp/-/commit/70372975261f2fc89aa9bbf92fe975a7663ef59f
Please rebase pr with merged changes from #368691. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix commit message of 771cf
to be accordance of CONTRIBUTING.md
@Eveeifyeve That is a fixup commit that will be squashed into the previous commit when this is ready for merge, as is common Git practice. I appreciate you’re enthusiastic about helping out, but as previously requested I’d like to suggest you please avoid leaving review feedback for things you don’t fully understand until you’ve gained more experience in Nixpkgs, as it takes up the time of experienced contributors like @jtojnar and anyone who is subscribed to this PR. |
Trying to see if we need any changes on Darwin.
Depends on #73833
closes #333800