Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gimp: 2.10.38 → 3.0.0-RC2 #67576

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

gimp: 2.10.38 → 3.0.0-RC2 #67576

wants to merge 8 commits into from

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 27, 2019 •
edited by dotlambda
Loading

Trying to see if we need any changes on Darwin.

Depends on #73833

closes #333800

@jtojnar jtojnar added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Sep 9, 2019
@jtojnar jtojnar mentioned this pull request Oct 31, 2019
Merged
1 task
@jtojnar
Copy link
Member Author

jtojnar commented Nov 5, 2019

The gjs failure will require #72805

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Nov 5, 2019
worldofpeace
worldofpeace reviewed Nov 5, 2019
View reviewed changes
pkgs/applications/graphics/gimp/default.nix Outdated
];

buildInputs = [
python3
Copy link
Contributor

@worldofpeace worldofpeace Nov 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this won't work if it ends up in a shebang for darwin (because wrappers).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah. Hoping for C wrappers before GIMP 3 is released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news! makeBinaryWrapper is a thing now: #124556

@jtojnar jtojnar force-pushed the gimp-meson branch 2 times, most recently from 715ab15 to f52c409 Compare November 20, 2019 22:02
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 20, 2019
@jtojnar jtojnar changed the title gimp: switch to unstable gimp: Testing dev version with Meson Nov 21, 2019
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 21, 2019
@jtojnar jtojnar force-pushed the gimp-meson branch 2 times, most recently from c750da1 to 359513f Compare November 21, 2019 22:58
@jtojnar jtojnar mentioned this pull request Nov 27, 2019
Merged
10 tasks
@jtojnar
Copy link
Member Author

jtojnar commented Dec 13, 2019

@GrahamcOfBorg eval

@jtojnar jtojnar mentioned this pull request Dec 25, 2019
Merged
17 tasks
@jtojnar jtojnar force-pushed the gimp-meson branch 2 times, most recently from d83954d to 65d90f9 Compare January 25, 2020 22:09
@jtojnar jtojnar mentioned this pull request Nov 7, 2024
Closed
13 tasks
@Eveeifyeve
Copy link
Contributor

Is this PR abandoned?

@lf-
Copy link
Member

lf- commented Dec 15, 2024

Is this PR abandoned?

i don't expect so, it's more that it probably should be in a different format while gnu imp 3.x is still in dev

also btw there's a bug where the meson build type is wrong so there's no optimization and the performance sucks

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Dec 27, 2024
@jtojnar jtojnar changed the title gimp: Testing dev version with Meson gimp: 2.10.38 → 3.0.0-RC1 Dec 27, 2024
@jtojnar
Copy link
Member Author

jtojnar commented Dec 27, 2024 •
edited
Loading

Is this PR abandoned?

I update it as time permits. Just bumped it to 3.0.0-RC1.

also btw there's a bug where the meson build type is wrong so there's no optimization and the performance sucks

How do you determine that? We use the plain meson build type so the optimization flags from stdenv should apply. This should be -O2 by default IIRC.

Edit: Yeah, default-enabled fortify hardening does -O2, which should be the same as the debugoptimized mode of Meson, which GIMP defaults to.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 27, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 27, 2024
@ofborg ofborg bot requested a review from AndersonTorres December 27, 2024 19:45
@jtojnar jtojnar changed the title gimp: 2.10.38 → 3.0.0-RC1 gimp: 2.10.38 → 3.0.0-RC2 Dec 28, 2024
jtojnar and others added 6 commits December 28, 2024 02:09
@jtojnar @lheckemann
gimp: testing dev builds
9c76013 
Co-Authored-By: Linus Heckemann <git@sphalerite.org>
@jtojnar
gimp: 2.99.10-unstable-2022-06-28 → 2.99.12-unstable-2022-08-31
85f67e4 
https://www.gimp.org/news/2022/08/27/gimp-2-99-12-released/
GNOME/gimp@256b2d9...a791151

Introduces `gimp-script-fu-interpreter-3.0` as interpreter invoked by shebang of some plug-ins. Let’s ensure it is on `PATH`.
@jtojnar
gimp: 2.99.12-unstable-2022-08-31 → 2.99.14-unstable-2023-03-17
0c0269e 
GNOME/gimp@a791151...ad7a2e5

Adds OpenMP support.
@jtojnar
gimp: 2.99.14-unstable-2023-03-17 → 3.0.0-RC1
e31cc9b 
GNOME/gimp@ad7a2e5...GIMP_3_0_0_RC1

- gtk-mac-integration dependency removed https://gitlab.gnome.org/GNOME/gimp/-/commit/df4ed9c1ec85117747e41e4540cb75b02284bdbe
- Python plug-in mandatory https://gitlab.gnome.org/GNOME/gimp/-/commit/93cc81281cd12c55139f483d65629be9c31e798d
- Only Lua 5.1 is supported https://gitlab.gnome.org/GNOME/gimp/-/commit/70372975261f2fc89aa9bbf92fe975a7663ef59f
@jtojnar
gegl: 0.4.50 → 0.4.52
bbe79fd 
https://gitlab.gnome.org/GNOME/gegl/-/compare/GEGL_0_4_50...GEGL_0_4_52
@jtojnar
gimp: 3.0.0-RC1 → 3.0.0-RC2
4821365 
https://www.gimp.org/news/2024/12/27/gimp-3-0-RC2-released/
GNOME/gimp@GIMP_3_0_0_RC1...GIMP_3_0_0_RC2
@jtojnar jtojnar mentioned this pull request Dec 28, 2024
Merged
13 tasks
@Eveeifyeve Eveeifyeve added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 28, 2024
@Eveeifyeve
Copy link
Contributor

Please rebase pr with merged changes from #368691.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 30, 2024
Eveeifyeve
Eveeifyeve reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@Eveeifyeve Eveeifyeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix commit message of 771cf to be accordance of CONTRIBUTING.md

@emilazy
Copy link
Member

emilazy commented Dec 30, 2024

@Eveeifyeve That is a fixup commit that will be squashed into the previous commit when this is ready for merge, as is common Git practice. I appreciate you’re enthusiastic about helping out, but as previously requested I’d like to suggest you please avoid leaving review feedback for things you don’t fully understand until you’ve gained more experience in Nixpkgs, as it takes up the time of experienced contributors like @jtojnar and anyone who is subscribed to this PR.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@Eveeifyeve Eveeifyeve Eveeifyeve left review comments

@sikmir sikmir Awaiting requested review from sikmir

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.