Ensure blas produces pkg config files #67629
Conversation
| @@ -44,6 +44,19 @@ stdenv.mkDerivation rec { | |||
| install ${dashD} -m755 libblas.so.${version} "$out/lib/libblas.so.${version}" | |||
| ln -s libblas.so.${version} "$out/lib/libblas.so.3" | |||
| ln -s libblas.so.${version} "$out/lib/libblas.so" | |||
| # Write pkgconfig aliases. Upstream report: | |||
| # https://github.com/xianyi/OpenBLAS/issues/1740 | |||
There was a problem hiding this comment.
Upstream isn't relevant here. There might be a relevant issue tracker for blas though.
There was a problem hiding this comment.
I think the discussion in that ticket is quite useful even though it is talking about openblas. I can remove the comment if that is going to stop this being accepted.
There was a problem hiding this comment.
I actually find the comment misleading since blas and openblas are from very different sources.
| @@ -44,6 +44,19 @@ stdenv.mkDerivation rec { | |||
| install ${dashD} -m755 libblas.so.${version} "$out/lib/libblas.so.${version}" | |||
| ln -s libblas.so.${version} "$out/lib/libblas.so.3" | |||
| ln -s libblas.so.${version} "$out/lib/libblas.so" | |||
| # Write pkgconfig aliases. Upstream report: | |||
| # https://github.com/xianyi/OpenBLAS/issues/1740 | |||
There was a problem hiding this comment.
I actually find the comment misleading since blas and openblas are from very different sources.
| # https://github.com/xianyi/OpenBLAS/issues/1740 | ||
| # This is a copy from openblas/default.nix | ||
| mkdir $out/lib/pkgconfig | ||
| for alias in blas cblas lapack; do |
There was a problem hiding this comment.
This package only contains blas. cblas and lapack are not part of this package. However openblas provides those interfaces.
| Name: $alias | ||
| Version: ${version} | ||
| Description: $alias provided by the BLAS package. | ||
| Cflags: -I$out/include |
There was a problem hiding this comment.
Since blas is a simple Fortran library it does not have includes. This is the complete file listing of nix-build -A blas:
result/
result/lib
result/lib/libblas.so.3
result/lib/libblas.so.3.8.0
result/lib/libblas.so
result/lib/libblas.a
|
@GrahamcOfBorg build blas |
Motivation for this change
Some Haskell packages use
PkgConfig-Depends: blasand currently theblaspackage doesn't produce these.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"I tried to use this but
and
./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @
There doesn't seem to be a maintainer (at least I couldn't find one in the
default.nix)