freecad: fix missing app icon and name when running under Wayland #67732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes the problem where the app icon would not show under Gnome/Wayland.
Wayland needs to know the name of the .desktop file to show a dock icon and application name.
See: https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Application_Icon
Tested on Gnome/Wayland with the QT backend forced to Wayland, ie
QT_QPA_PLATFORM=wayland
. IfQT_QPA_PLATFORM
is unset (or is set toxcb
) it uses XWayland.The patch has been upstreamed and can be removed once a new release is available.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @viric @gebner