targetcli: 2.1.fb49 -> 2.1.51 #67749

markuskowa · 2019-08-30T07:33:09Z

Motivation for this change

Regular update. Now the man page is also installed.

Things done

Notify maintainers

cc @

pkgs/os-specific/linux/targetcli/default.nix

ajs124 · 2019-08-30T14:05:15Z

With the dependencies updated, we arrive at the age old question: did you test this with an actual iSCSI setup?

markuskowa · 2019-08-30T14:11:20Z

I did a local test with the the open-iscsi initiator and the targetcli/fileio backend on my laptop (before I updated the libraries), which worked fine. A great thing to have would be a NixOS test, that covers a few basic scenarios.

markuskowa · 2019-08-31T16:56:57Z

@GrahamcOfBorg test iscsi

markuskowa · 2019-09-07T18:39:03Z

The test works just fine when I build it locally. Any ideas why it fails with ofBorg?

ajs124 · 2019-09-07T21:22:54Z

Seems to work for me locally, as well. @grahamc do you have any insights?

Mic92 · 2019-09-24T06:23:10Z

nixos/tests/iscsi.nix

+
+    # Check client login
+    $client->waitForUnit("multi-user.target");
+    $client->succeed("iscsistart -i ${initiatorName} -t ${targetName} -g 1 -a server");


Maybe a race condition?

Suggested change

$client->succeed("iscsistart -i ${initiatorName} -t ${targetName} -g 1 -a server");

$client->waitUntilSucceeds("iscsistart -i ${initiatorName} -t ${targetName} -g 1 -a server");

Thanks that seems to work.

Sorry, I got something wrong here. Still fails with ofBorg.

Is the command necessary after all or what does:

iscsistart: initiator reported error (15 - session exists)

mean?

iscsistart connects manually to the server (target). It is required to create new iSCSI provided block devices on the client ("/dev/sda" and "/dev/sdb" in this case). The message session exists means that the connect worked only half way at the first try (it somehow connected to the target but still failed).

JohnAZoidberg · 2019-09-24T07:02:38Z

This is awesome!

I've been trying out the iSCSI infrastructure on NixOS recently and I'm planning to create a test and maybe module for tgt, as it allows declarative configuration. So I'd suggest to rename this test to targetcli.

markuskowa · 2019-09-25T12:42:13Z

@JohnAZoidberg I was also looking at tgt. However, it seems that this package is quite old and the recommended version is now targetcli, which is said to be more performant (uses the kernel space iscsi target). There might be a chance to use declarative configuration with targetcli: the tool stores and reads its config from a json file. Maybe that could be integrated in a nix module somehow?

JohnAZoidberg

Even though tgt is still maintained, it looks like targetcli is more or less a replacement:

Yes, it does look like we can use the JSON config to declaratively configure it. I wasn't aware of that before. I'll try that.
Alright, I'm for having targetcli as NixOS' default iSCSI toolchain.

JohnAZoidberg · 2019-11-05T17:39:35Z

This should be good, even works, when rebased on top of the latest master.

I'm working on the declarative service module but the JSON config seems to be too complicated to generate, completely, ourselves.

JohnAZoidberg · 2019-11-05T17:57:20Z

Oh and by the way, it looks like we've migrated off of Perl and to Python for the tests; and all tests are being rewritten.
So it'd be good to port this to Python. (Looks trivial)

markuskowa · 2019-11-05T21:16:05Z

I think we we can leave the test in Perl for now and convert it later when new Python test frame work is more mature.

JohnAZoidberg · 2019-11-06T12:39:48Z

It sure looks like the Python framework is on-par and we're going all in: #72828

I'm quite stumped by this sudden change without a proper RFC or announcement :/

jonringer · 2019-11-06T18:47:40Z

I guess there was some discussion at nixcon, and there seemed to be consensus

markuskowa · 2019-11-06T23:30:56Z

Yes, the switch to python was quite quick but it I think it is a good thing to move away from perl.

The test is now in python and works fine (only GrahamcOfBorg seems to still have problems with it).

pkgs/os-specific/linux/targetcli/default.nix

* install man page

markuskowa · 2019-11-07T11:34:51Z

@jonringer should we merge it now?

jonringer · 2019-11-07T17:14:37Z

when trying to run the tests locally, i got:

client: must succeed: iscsistart -i iqn.2004-01.org.nixos:initiator -t iqn.2004-01.org.nixos:target -g 1 -a server
client # [   84.446956] Loading iSCSI transport class v2.0-870.
client # iscsistart: version 2.0-878
client # [   85.448936] iscsi: registered transport (tcp)
client # iscsistart: initiator reported error (15 - session exists)
client # [   86.409030] scsi host2: iSCSI Initiator over TCP/IP
client # [   86.518122]  connection1:0: detected conn error (1011)
client: output: iscsistart: Logging into iqn.2004-01.org.nixos:target server:3260,1

error: command `iscsistart -i iqn.2004-01.org.nixos:initiator -t iqn.2004-01.org.nixos:target -g 1 -a server` failed (exit code 1)
cleaning up

jonringer · 2019-11-07T17:14:50Z

@GrahamcOfBorg test iscsi

markuskowa · 2019-11-07T21:39:59Z

That is strange I can run the test locally.

ajs124 · 2019-11-08T10:28:13Z

@jonringer should we merge it now?

Upstream seems to have release 2.1.51 in the meantime.

markuskowa · 2019-11-10T22:26:08Z

I did update all packages to the latest version. ~~The test seems to be more stable now x86 but still is a bit shaky on ARM. Any suggestions?~~

~~Making sure that the iSCSI target can only be reached with via a single network interface seems to solve the problem with the unreliable test.~~

JohnAZoidberg · 2019-11-15T09:39:26Z

Test fails on x64 nixos for me :(

client # [  256.637003] systemd[1]: Reached target Multi-User System.
client # [  256.669568] systemd[1]: Startup finished in 1min 10.998s (kernel) + 3min 5.582s (userspace) = 4min 16.581s.
client: waiting for success: ping -c 1 server
(0.58 seconds)
client: must succeed: iscsistart -i iqn.2004-01.org.nixos:initiator -t iqn.2004-01.org.nixos:target -g 1 -a server
client # [  259.585977] Loading iSCSI transport class v2.0-870.
client # iscsistart: version 2.0-878
client # [  260.640047] iscsi: registered transport (tcp)
client # iscsistart: initiator reported error (15 - session exists)
client # [  261.415787] scsi host2: iSCSI Initiator over TCP/IP
client # [  261.688013]  connection1:0: detected conn error (1011)
client: output: iscsistart: Logging into iqn.2004-01.org.nixos:target server:3260,1

error: command `iscsistart -i iqn.2004-01.org.nixos:initiator -t iqn.2004-01.org.nixos:target -g 1 -a server` failed (exit code 1)

markuskowa · 2019-11-15T13:41:18Z

@JohnAZoidberg I am almost about to give up on the test. It seems to be reliably unreliable. My guess is that iscsistart does not like it when there are more than two network interfaces available (there are some mentions on google). I can't see a way to eliminate the problem.
Using iscsistart to test the functionality seems just not to be the right approach. Maybe the best way is to implement some basic NixOS modules for targetcli/iscsid first and and then base the test on iscsid/iscsiadm.

JohnAZoidberg · 2019-11-15T13:53:52Z

Maybe the best way is to implement some basic NixOS modules for targetcli/iscsid first and and then base the test on iscsid/iscsiadm.

Yes, that seems reasonable. I'm already working on that.

But for now I suggest we just merge the package updates and you could open another WIP PR for the test, I'd be interested to figure it out.

Are you using iSCSI on NixOS for anything other than testing?

JohnAZoidberg · 2019-11-15T13:55:10Z

According to this my error and the one on ofBorg for ARM means that the initiator is timing out, while connecting to the target.

markuskowa · 2019-11-17T14:06:12Z

@JohnAZoidberg I am not using iSCSI at the moment but I want to in the future (hopefully with iSCSI root at some point).
Should we proceed like this: I will remove the the test from this PR. Since you are already working on a NixOS module the test will fit better into your PR. Feel free to just copy the test if you want to use it as a starting point.

JohnAZoidberg · 2019-11-17T14:20:07Z

Alright, sounds good, you can remove it.

Ohh, iSCSI root, that'll be interesting and probably doesn't work out of the box on NixOS right now.

markuskowa · 2019-11-17T15:53:44Z

OK, done

Ohh, iSCSI root, that'll be interesting and probably doesn't work out of the box on NixOS right now.

Yeah, that will probably require some more work to make it run smoothly.

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 30, 2019

markuskowa requested a review from ajs124 August 30, 2019 08:31

ajs124 reviewed Aug 30, 2019

View reviewed changes

pkgs/os-specific/linux/targetcli/default.nix Show resolved Hide resolved

markuskowa requested a review from FRidh as a code owner August 30, 2019 11:08

ofborg bot added 6.topic: python 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Aug 30, 2019

ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Aug 31, 2019

markuskowa force-pushed the upd-targetcli branch 3 times, most recently from 85aaa1a to ac85b19 Compare September 7, 2019 13:00

Mic92 reviewed Sep 24, 2019

View reviewed changes

markuskowa force-pushed the upd-targetcli branch from ac85b19 to 3ba6693 Compare September 25, 2019 12:37

JohnAZoidberg approved these changes Sep 25, 2019

View reviewed changes

markuskowa mentioned this pull request Oct 4, 2019

slurm: 19.05.2.1 -> 19.05.3.2 #70373

Merged

10 tasks

markuskowa added 2 commits November 5, 2019 22:03

pythonPackages.rtslib: 2.1.fb69 -> 2.1.70

d096ee5

pythonPackages.configshell: 1.1.fb25 -> 1.1.26

7c8f37b

markuskowa force-pushed the upd-targetcli branch from 3ba6693 to 003b9bc Compare November 5, 2019 21:10

markuskowa requested a review from jonringer as a code owner November 5, 2019 21:10

JohnAZoidberg reviewed Nov 6, 2019

View reviewed changes

pkgs/os-specific/linux/targetcli/default.nix Outdated Show resolved Hide resolved

targetcli: 2.1.fb49 -> 2.1.50

220f04f

* install man page

markuskowa force-pushed the upd-targetcli branch from baeb01f to 4816ab2 Compare November 7, 2019 08:51

JohnAZoidberg approved these changes Nov 7, 2019

View reviewed changes

markuskowa changed the title ~~targetcli: 2.1.fb49 -> 2.1.50~~ targetcli: 2.1.fb49 -> 2.1.51 Nov 8, 2019

markuskowa force-pushed the upd-targetcli branch from d6bc374 to 82c38ea Compare November 8, 2019 13:29

markuskowa force-pushed the upd-targetcli branch from b889afc to b389a83 Compare November 13, 2019 08:38

markuskowa added 3 commits November 17, 2019 16:50

pythonPackages.configshell: 1.1.26 -> 1.1.27

2c067b4

pythonPackages.rtslib: 2.1.70 -> 2.1.71

1b9b0dd

targetcli: 2.1.50 -> 2.1.51

6b39472

markuskowa force-pushed the upd-targetcli branch from b389a83 to 6b39472 Compare November 17, 2019 15:51

ofborg bot removed the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 17, 2019

JohnAZoidberg merged commit 09f9bcd into NixOS:master Nov 20, 2019

markuskowa deleted the upd-targetcli branch May 25, 2021 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

targetcli: 2.1.fb49 -> 2.1.51 #67749

targetcli: 2.1.fb49 -> 2.1.51 #67749

markuskowa commented Aug 30, 2019

ajs124 commented Aug 30, 2019

markuskowa commented Aug 30, 2019

markuskowa commented Aug 31, 2019 •

edited

Loading

markuskowa commented Sep 7, 2019

ajs124 commented Sep 7, 2019

Mic92 Sep 24, 2019

markuskowa Sep 25, 2019

markuskowa Sep 27, 2019

Mic92 Sep 30, 2019

markuskowa Sep 30, 2019 •

edited

Loading

JohnAZoidberg commented Sep 24, 2019

markuskowa commented Sep 25, 2019 •

edited

Loading

JohnAZoidberg left a comment •

edited

Loading

JohnAZoidberg commented Nov 5, 2019

JohnAZoidberg commented Nov 5, 2019

markuskowa commented Nov 5, 2019

JohnAZoidberg commented Nov 6, 2019

jonringer commented Nov 6, 2019

markuskowa commented Nov 6, 2019

markuskowa commented Nov 7, 2019

jonringer commented Nov 7, 2019

jonringer commented Nov 7, 2019

markuskowa commented Nov 7, 2019

ajs124 commented Nov 8, 2019

markuskowa commented Nov 10, 2019 •

edited

Loading

JohnAZoidberg commented Nov 15, 2019

markuskowa commented Nov 15, 2019 •

edited

Loading

JohnAZoidberg commented Nov 15, 2019

JohnAZoidberg commented Nov 15, 2019

markuskowa commented Nov 17, 2019

JohnAZoidberg commented Nov 17, 2019

markuskowa commented Nov 17, 2019

	$client->succeed("iscsistart -i ${initiatorName} -t ${targetName} -g 1 -a server");
	$client->waitUntilSucceeds("iscsistart -i ${initiatorName} -t ${targetName} -g 1 -a server");

targetcli: 2.1.fb49 -> 2.1.51 #67749

targetcli: 2.1.fb49 -> 2.1.51 #67749

Conversation

markuskowa commented Aug 30, 2019

Motivation for this change

Things done

Notify maintainers

ajs124 commented Aug 30, 2019

markuskowa commented Aug 30, 2019

markuskowa commented Aug 31, 2019 • edited Loading

markuskowa commented Sep 7, 2019

ajs124 commented Sep 7, 2019

Mic92 Sep 24, 2019

Choose a reason for hiding this comment

markuskowa Sep 25, 2019

Choose a reason for hiding this comment

markuskowa Sep 27, 2019

Choose a reason for hiding this comment

Mic92 Sep 30, 2019

Choose a reason for hiding this comment

markuskowa Sep 30, 2019 • edited Loading

Choose a reason for hiding this comment

JohnAZoidberg commented Sep 24, 2019

markuskowa commented Sep 25, 2019 • edited Loading

JohnAZoidberg left a comment • edited Loading

Choose a reason for hiding this comment

JohnAZoidberg commented Nov 5, 2019

JohnAZoidberg commented Nov 5, 2019

markuskowa commented Nov 5, 2019

JohnAZoidberg commented Nov 6, 2019

jonringer commented Nov 6, 2019

markuskowa commented Nov 6, 2019

markuskowa commented Nov 7, 2019

jonringer commented Nov 7, 2019

jonringer commented Nov 7, 2019

markuskowa commented Nov 7, 2019

ajs124 commented Nov 8, 2019

markuskowa commented Nov 10, 2019 • edited Loading

JohnAZoidberg commented Nov 15, 2019

markuskowa commented Nov 15, 2019 • edited Loading

JohnAZoidberg commented Nov 15, 2019

JohnAZoidberg commented Nov 15, 2019

markuskowa commented Nov 17, 2019

JohnAZoidberg commented Nov 17, 2019

markuskowa commented Nov 17, 2019

markuskowa commented Aug 31, 2019 •

edited

Loading

markuskowa Sep 30, 2019 •

edited

Loading

markuskowa commented Sep 25, 2019 •

edited

Loading

JohnAZoidberg left a comment •

edited

Loading

markuskowa commented Nov 10, 2019 •

edited

Loading

markuskowa commented Nov 15, 2019 •

edited

Loading