-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google-compute-config.nix: fix comments, update google-*.service units, fix paths in gce #67848
Conversation
also move OS Login next to it, for better understandability
With local-fs.target part of sysinit.target (NixOS#61321), we don't need to add it explicitly to certain units anymore, and can change dependencies like they are in other distros (I picked from Google's official CentOS 7 image here). Like them, use StandardOutput=journal+console to pipe google-*.service output to the serial console as well.
I tested this by successfully booting a new GCP instance based on this config. The services still boot up. There's some missing shebangs in some scripts (which were before too, will update the google-compute-engine accordingly. |
I patched shebangs and fixed paths. The scripts previously erroring into syslog are now properly executed. We now set |
…PATH It executes bin/google_set_multiqueue which will execute basename
667300f
to
d658dd4
Compare
I also verified startup and shutdown scripts configured in metadata are properly executed:
|
We make them available at ${gce}/sysctl.d and add them to environments.etc, like we do with the systemd ones.
Motivation for this change
With local-fs.target part of sysinit.target
(#61321), we don't need to add it
explicitly to certain units anymore, and can change dependencies like
they are in other distros (I picked from Google's official CentOS 7
image here).
Like them, use StandardOutput=journal+console to pipe google-*.service
output to the serial console as well.
Update comment about ssh login and move enabling OS Login (together with
a comment) next to it
Remove a comment accidentially copied over from
amazon-image.nix
.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @