Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken builds for rgdal and sf R packages #67948

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Fix broken builds for rgdal and sf R packages #67948

merged 1 commit into from
Sep 2, 2019

Conversation

cfhammill
Copy link
Contributor

Motivation for this change

Build rgdal and sf R packages was failing. See #67947

Things done

Add build dependencies on the PROJ geospatial library.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) [I loaded the libraries and inspected the shared objects with ldd to ensure everything linked correctly]
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cfhammill
Fix broken builds for rgdal and sf R packages
8e5aae5 
Builds were failing to include PROJ, depending on proj.dev
appears to fix it.
@cfhammill cfhammill requested a review from peti as a code owner September 2, 2019 13:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 2, 2019
@peti peti merged commit 22fb5e5 into NixOS:master Sep 2, 2019
@cfhammill cfhammill mentioned this pull request Jun 2, 2020
Closed
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfhammill @peti @Janik-Haag