-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default gcc to gcc9 #68029
Default gcc to gcc9 #68029
Conversation
Rebased onto current master. Created hydra jobset: https://hydra.nixos.org/jobset/nixpkgs/gcc-9 Already built firefox and its dependencies successfully. This might be an easy bump. \o/ |
Some tests don't work well with gcc9 atm, those tests use CC from `buildPackages.stdenv.cc` which had to be modified for Aarch64 as well.
Newer `iasl`-versions disallow strings within certain declarations[1] which breaks the virtualbox build as it relies on exactly this behavior[2]. This should be removed again when updating virtualbox to 6.1. [1] https://acpica.org/node/172 [2] https://hydra.nixos.org/build/108774352
The Hydra builds look good. Is there an intent to merge this in the coming days? Both this branch and staging-next seem ready, so depending on how we merge we will need to do at least one more rebuild of either. |
@FRidh Yup, that was our intention. There are still some minor packages that are failing but are difficult to fix. The maintainers have to take care of those. Since I'm not involved in the current staging processes, when would be the best time to merge in your opinion? We wanted to do another master-merge and eval since we wanted to test if the go aarch64 build fail is finally fixed. |
Great! I'm going to merge |
These changes are now in |
Great, thanks! |
Awesome! Thanks! 🎉 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/1 |
Successor of #63132, based on it.
This will receive a hydra jobset after the above has been merged.