Staging next that includes gcc8 #68244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the `-Wno-error=array-bounds` flag. Fixes #40213.
systemd: suppress certain warnings to compile under gcc8
This test is broken because gcc8.x86_64-darwin is broken. Please add the test back in once we have fixed it! Job: https://hydra.nixos.org/job/nixpkgs/trunk/gcc8.x86_64-darwin Issue: #40038
gcc,gcc8: {revert gcc to gcc7, mark gcc8 as broken} on Darwin
gcc8: merge branch master
llvm6: default to gcc7 instead of gcc8
iasl: 20180313 -> 20180508, temporary fix for upstream issue #387
* elfutils: add patch that fixes compilation under gcc8 * elfutils: follow advice from @jtojnar
Broke xen and virtualbox. This reverts commit d2f2132.
|
No, see comments on #63132 |
|
@vcunat will you merge gcc-8 or shall I? |
|
I can't make it today. |
Earlier the gcc8 branch was merged instead of the gcc-8 branch (note the dash)...
|
OK. Now gcc-8 is in (5f4734b). |
|
Would you consider picking #68096 for this iteration of staging next as well? It seems to be fairly low impact on the overall systems besides the extra rebuilds. Having this through staging would help us having it accepted for 19.09. |
|
Oh, I wondered if this release should only get one large feature merged on the last day (which is past the planned fork-off date), but apparently we end up the same on every release :-) |
The build was fixed in two ways, by both this patch and a substitution. Let's keep the substitition instead of the patch as the patches may disappear. This reverts commit ccc8c73.
|
proposed eval fix #68324 |
This was present in the gcc-8 branch but got removed in the merge.
|
It seems this merge broke building my builds with musl (due to a new |
nh2
added a commit
to nh2/nixpkgs
that referenced
this pull request
Oct 21, 2019
See * NixOS#68244 (comment) * nh2/static-haskell-nix#56 This commit takes care to not change the derivation for non-musl builds.
10 tasks
PR to fix it: #71480 |
nh2
added a commit
to nh2/nixpkgs
that referenced
this pull request
Oct 30, 2019
GCC 8 introduced new warnings that were picked up by -Werror; this commit makes them non-errors until fixed upstream. See * NixOS#68244 (comment) * nh2/static-haskell-nix#56 This commit takes care to not change the derivation for non-musl builds.
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 4, 2020
GCC 8 introduced new warnings that were picked up by -Werror; this commit makes them non-errors until fixed upstream. See * NixOS#68244 (comment) * nh2/static-haskell-nix#56 This commit takes care to not change the derivation for non-musl builds. (cherry picked from commit 08ec575)
louisblin
reviewed
Nov 20, 2020
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @