Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon 5.1 #69052

Merged
merged 26 commits into from
Nov 3, 2019
Merged

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Mostly waiting on some tasks in https://github.com/orgs/elementary/projects/54
such as the wingpanel-indicator-datetime release so it can use the new AccountsService extension.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace self-assigned this Sep 18, 2019
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Sep 18, 2019
@worldofpeace worldofpeace added the 2.status: work-in-progress This PR isn't done label Sep 25, 2019
@worldofpeace worldofpeace force-pushed the elementary-updates-maybe-5.1 branch from 1ff4d0f to d8aa052 Compare October 2, 2019 02:16
@worldofpeace worldofpeace force-pushed the elementary-updates-maybe-5.1 branch from d8aa052 to 523ad2a Compare October 5, 2019 10:46
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 5, 2019
@worldofpeace worldofpeace force-pushed the elementary-updates-maybe-5.1 branch from 523ad2a to 3d6ace1 Compare October 6, 2019 15:35
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 6, 2019
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Oct 10, 2019
@worldofpeace worldofpeace force-pushed the elementary-updates-maybe-5.1 branch 2 times, most recently from c7cc5ab to 42e3de8 Compare October 12, 2019 18:39
@worldofpeace worldofpeace force-pushed the elementary-updates-maybe-5.1 branch from 42e3de8 to 24e2caa Compare October 31, 2019 22:37
Unfortunately elementary has suddenly decided to add ${version}-debian
tags into the mix which ls-remote will always sort last. I believe these tags
point to the deb-packaging branches in the repo's which we certainly
don't ever want to use as they contain no source.
@worldofpeace worldofpeace force-pushed the elementary-updates-maybe-5.1 branch from 24e2caa to 0bc0bb9 Compare November 1, 2019 01:16
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 1, 2019
@worldofpeace worldofpeace force-pushed the elementary-updates-maybe-5.1 branch from da8165c to d6cf494 Compare November 3, 2019 16:41
@worldofpeace worldofpeace marked this pull request as ready for review November 3, 2019 16:42
@worldofpeace worldofpeace removed the 2.status: work-in-progress This PR isn't done label Nov 3, 2019
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Nov 3, 2019

They've made all their releases over the past two days. Let's go 🌃
(just waiting on eval...)

@worldofpeace worldofpeace merged commit c751f60 into NixOS:master Nov 3, 2019
@worldofpeace worldofpeace deleted the elementary-updates-maybe-5.1 branch November 3, 2019 17:03
@bobby285271 bobby285271 mentioned this pull request Aug 11, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: pantheon The Pantheon desktop environment 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant