Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xzoom: fix version #71528

Merged
merged 1 commit into from
Oct 21, 2019
Merged

xzoom: fix version #71528

merged 1 commit into from
Oct 21, 2019

Conversation

davidak
Copy link
Member

@davidak davidak commented Oct 21, 2019

Motivation for this change

This should fix the issue repology reported:

xzoom: ERROR: name "xzoom-0.3.24" does not end with version "0.3"

but it makes it also more verbose

Related to #68531

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@ofborg ofborg bot requested a review from 7c6f434c October 21, 2019 13:19
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Oct 21, 2019
@7c6f434c 7c6f434c merged commit a2f854b into NixOS:master Oct 21, 2019
@davidak davidak deleted the xzoom branch October 22, 2019 13:16
@davidak davidak mentioned this pull request Oct 28, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidak @7c6f434c