Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port tests to Python #72887

Merged
merged 15 commits into from
Nov 7, 2019
Merged

Port tests to Python #72887

merged 15 commits into from
Nov 7, 2019

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Nov 6, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 6, 2019
@tfc tfc mentioned this pull request Nov 6, 2019
Closed
@mmahut
Copy link
Member

mmahut commented Nov 7, 2019

@GrahamcOfBorg test trickster
@GrahamcOfBorg test yabar
@GrahamcOfBorg test zookeeper
@GrahamcOfBorg test upnp
@GrahamcOfBorg test morty
@GrahamcOfBorg test moodle
@GrahamcOfBorg test xautolock
@GrahamcOfBorg test telegraf
@GrahamcOfBorg test strongswan-swanctl
@GrahamcOfBorg test snapper
@GrahamcOfBorg test radarr
@GrahamcOfBorg test redis
@GrahamcOfBorg test roundcube
@GrahamcOfBorg test rss2email
@GrahamcOfBorg test signal-desktop

@mmahut mmahut merged commit 1a65fc1 into NixOS:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1000101 @mmahut @tfc @flokli @andir