-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tests to Python #72935
Port tests to Python #72935
Conversation
b2f84af
to
017889c
Compare
017889c
to
f04daa6
Compare
a4cac83
to
2c3785a
Compare
@worldofpeace I've dropped the commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cadvisor failed for me:
builder for '/nix/store/v36812mciwfpddsbkkk49ysv2g1x9kfm-vm-test-run-cadvisor.drv' failed with exit code 1; last 10 log lines:
machine # [ 646.651689] systemd[1]: cadvisor.service: Failed with result 'timeout'.
machine # [ 646.677454] systemd[1]: Failed to start cadvisor.service.
machine # [ 646.696165] systemd[1]: cadvisor.service: Consumed 1min 6.085s CPU time, received 3.0K IP traffic, sent 4.5K IP traffic.
machine # [ 646.734438] systemd[1]: Reached target Multi-User System.
machine # [ 646.778982] systemd[1]: Startup finished in 1min 22.803s (kernel) + 9min 23.250s (userspace) = 10min 46.053s.
error: unit "cadvisor.service" reached state "failed"
cleaning up
killing influxdb (pid 9)
killing machine (pid 20)
(0.10 seconds)
[247 built (1 failed), 45 copied (635.3 MiB), 133.4 MiB DL]
error: build of '/nix/store/v36812mciwfpddsbkkk49ysv2g1x9kfm-vm-test-run-cadvisor.drv' failed
@jonringer I just started the build again after a fresh rebase and I couldn't reproduce the fail. It works for me:
|
I was also running a lot of other reviews at the time, could have been cpu starved and then timedout |
@GrahamcOfBorg test cadvisor |
Ran all the updated tests manually, and they did succeed. Thanks :-) |
Motivation for this change
Processing the task list in issue #72828.
Now that PR #71684 (nixos: add python testing support) by @tfc got merged, I would like to port some of the tests to Python.
Things done
Ported several tests to Python, which also conform the Black code style.
Tests have been run and all of them succeed.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @tfc @flokli @worldofpeace