Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shiori: update modSha256, update test to python, do more tests #73063

Merged
merged 3 commits into from
Nov 8, 2019
Merged

shiori: update modSha256, update test to python, do more tests #73063

merged 3 commits into from
Nov 8, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

If I'm not wrong, the modSha256 modification means that this derivation is only compatible with Go 1.13, and not < 1.13

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

That's me :)

@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 8, 2019
@ofborg ofborg bot requested a review from kalbasit November 8, 2019 17:09
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 8, 2019
@kalbasit
Copy link
Member

kalbasit commented Nov 8, 2019

@GrahamcOfBorg build shiori
@GrahamcOfBorg test shiori

@minijackson
Copy link
Member Author

You are waaay too fast x)

@kalbasit
Copy link
Member

kalbasit commented Nov 8, 2019

You are waaay too fast x)

lol I was just about to start my day when I got the notification, seemed like a good context switch from my coffee 😄

@GrahamcOfBorg build shiori
@GrahamcOfBorg test shiori

@flokli flokli merged commit 3928e7f into NixOS:master Nov 8, 2019
@minijackson minijackson deleted the shiori-things branch November 9, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minijackson @kalbasit @flokli