nixosTests.plasma5: port to python #73134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
tfc
reviewed
Nov 9, 2019
flokli
added
the
9.needs: reporter feedback
|
@GrahamcOfBorg test plasma5 |
worldofpeace
referenced
this pull request
Nov 25, 2019
This was the behaviour in the perl test driver too and a regression. Also cleaned up unused imports
OCR in this test has been disabled.
worldofpeace
force-pushed
the
port-plasma5-test
branch
from
9e567e1 to
796a92a
Compare
|
@GrahamcOfBorg test plasma5 |
worldofpeace
removed
the
9.needs: reporter feedback
worldofpeace
force-pushed
the
port-plasma5-test
branch
from
796a92a to
87f3224
Compare
|
Uhh, kernel rebuild. This succeeded for me locally anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Note, a known issue with this test is the desktop doesn't actually get drawn or the panel before it exits.
This is problematic, and wait_for_window actually doesn't check if it's visible or not, so the desktop being broken visually isn't part of the tests coverage. Not sure if there's an API with plasma to check if everything is initialized and stable.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @