Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osquery: remove #74081

Merged
merged 1 commit into from
Nov 24, 2019
Merged

osquery: remove #74081

merged 1 commit into from
Nov 24, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 24, 2019

osquery was marked as broken since April.

If somebody steps up to fix it, we can always revive it from the
histroy, but there's not much value in shipping completely broken things
in current master.

cc @Ma27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

osquery was marked as broken since April.

If somebody steps up to fix it, we can always revive it from the
histroy, but there's not much value in shipping completely broken things
in current master.

cc @Ma27
@flokli flokli requested review from fpletz, globin and Ma27 November 24, 2019 21:40
@flokli flokli requested a review from infinisil as a code owner November 24, 2019 21:40
@flokli flokli mentioned this pull request Nov 24, 2019
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 24, 2019
@infinisil
Copy link
Member

infinisil commented Nov 24, 2019

Ping @Ma27 who indicated in #58834 (comment) to look into fixing the build (Edit: Oh you already pinged them, duh)

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use osquery anymore. I tried to look into this several times, but the build system is pretty complex (also due to our cmake-related patches for osquery).

I don't have the time and motivation atm to fix this, so if noone else steps up, I'd be fine with removing it.

@flokli
Copy link
Contributor Author

flokli commented Nov 24, 2019

So let's remove it. If somebody wants to get it going before the next release, we can add it back and remove it from the changelog.

@flokli flokli merged commit 4273a6a into NixOS:master Nov 24, 2019
@flokli flokli deleted the osquery branch November 24, 2019 23:17
Ma27 added a commit that referenced this pull request Dec 2, 2019
The package has been removed in #74081.
@abvbv abvbv mentioned this pull request May 4, 2021
@znewman01 znewman01 mentioned this pull request Oct 14, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants