Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua for sile #78432

Merged
merged 7 commits into from
Jan 25, 2020
Merged

Lua for sile #78432

merged 7 commits into from
Jan 25, 2020

Conversation

teto
Copy link
Member

@teto teto commented Jan 24, 2020

Motivation for this change

add missing packages for #77738

@doronbehar while regenerating the set, I noticed pulseaudio was generated. Maybe you could move you changes to lua-pulseaudio in pkgs/development/lua-modules/overrides.nix instead.

@Shados I've disabled parallel, I have never been able to complete a single update with a value != 1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: lua 8.has: package (new) This PR adds a new package labels Jan 24, 2020
@ofborg ofborg bot requested a review from 7c6f434c January 24, 2020 19:56
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jan 24, 2020
teto added 2 commits January 24, 2020 21:23
@teto
luaPackages.digestif: scm1 -> 0.2-1
5365e36 
Now it's a released package so no need to specify the manifest anymore.
@teto
luaPackages.linenoise: init at 0.9-1
bc07d11
@doronbehar
Copy link
Contributor

@teto could you point me to where did my Pulseaudio Lua module got generated? I didn't find it in the diff other then in the csv file...

@teto
Copy link
Member Author

teto commented Jan 24, 2020

I haven't committed the generated pulseaudio package (due to this line https://github.com/NixOS/nixpkgs/blame/master/maintainers/scripts/luarocks-packages.csv#L74) but if you run maintainers/scripts/update-luarocks-packages pkgs/development/lua-modules/generated-packages.nix you can see it is generated.

@teto
Copy link
Member Author

teto commented Jan 24, 2020

seems like linenoise needs an override, will update later.

@doronbehar
Copy link
Contributor

... but if you run maintainers/scripts/update-luarocks-packages pkgs/development/lua-modules/generated-packages.nix you can see it is generated.

I remember, that back when I wanted to add lua_pulseaudio to nixpkgs I considered just adding a line to the csv table and running the script. But, I figured that it would just update so many packages that many people would have to be mentioned and summoned for review in order for that PR to pass while I just want my package to be added. Hence, I added it where it is now - to top-level/lua-modules.nix.

Anyway, I don't care, as long as copying the make flags and everything to an override won't brake anything (and it shouldn't) feel free @teto to run the script and add an override in pkgs/development/lua-modules/overrides.nix.

@teto teto force-pushed the lua_for_sile branch 3 times, most recently from e12748f to 27c88c5 Compare January 25, 2020 17:39
teto added 5 commits January 25, 2020 19:39
@teto
luarocks-nix: fix generation when missing license
2edf9a0 
vstruct rockspec doesnt contain a license, which made luarocks-nix
crash. Bump luarocks nix to fix this.
@teto
luaPackages.luaepnf: init at 0.3-1
460224d
@teto
luaPackages.luarepl: init at 0.9-1
a032a3a
@teto
luaPackages.vstruct: init at 2.0.2-1
84a2134
@teto
update-luarocks-packages: disable by default
27c88c5 
Not only the binary `parallel` displays a re,inder to quote their
software but it systematically breaks update here regardless of my
network quality.
Better be slow than fail. If anyone can fix it, we may rollback this.
@teto teto merged commit 29b5473 into NixOS:master Jan 25, 2020
@teto
Copy link
Member Author

teto commented Jan 25, 2020

@doronbehar You don't have to submit all generated-packages.nix modifications. With git add -p, one can select updates only for his/her package. Anyway right now because pulseaudio is mentioned in the csv file, it generates some code so let's keep as much as possible generated.

If you don't beat me to it, I will prepare sthg next week.

@teto teto deleted the lua_for_sile branch January 25, 2020 19:51
@doronbehar
Copy link
Contributor

If you don't beat me to it, I will prepare sthg next week.

What do you mean by "beat me to it" and "sthg"? I noticed you still didn't merge here the pulseaudio and perhaps other updates to lua's generated package set right?

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 26, 2020
@teto @dtzWill
Merge pull request NixOS#78432 from teto/lua_for_sile
a8f8e3a 
Lua for sile

(cherry picked from commit 29b5473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: lua 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teto @doronbehar