-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inter: 3.11 -> 3.12 #79959
inter: 3.11 -> 3.12 #79959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Darwin build failed, can we fix this?
Thanks for catching this! Looks like they have a few variants to choose from-- Hinted ("for Windows") variants, ... err, here's the listing: https://gist.github.com/dtzWill/e956d2f197404acb5059e43c1ead3533 Not sure why Mac's unzip is behaving different (!) but glad it did because we should make an intentional choice here :). Hinted version seems the way to go? But upstream's instructions for Linux are to use unhinted-- I'm thinking user's font settings can choose to ignore hinting information and font size doesn't seem a significant concern (for Desktop use). Thoughts/input welcome, may want to be more particular than just this choice... |
Pantheon wants to use this font and they noticed kerning differences between variants elementary/default-settings#152 (comment). I don't really know much about fonts in macos though. |
I'd think we'd want to distribute all variants? They could even be in different outputs if desired. |
The hinted TTFs are just run through the FreeType2 ttfautohint, rather than being manually hinted. For Linux I would tend to prefer letting FreeType2 do its autohinting instead, both so that you get the choice yourself, and as you might be running a newer version with improved autohinting. We could certainly distribute the other variants as well however, since people might indeed have uses for the other variants. |
Confirmed darwin failure is a regression https://hydra.nixos.org/job/nixpkgs/nixpkgs-20.03-darwin/inter.x86_64-darwin |
Actually I think the conflict is due to case-sensitivity (or insensitivity on Darwin)-- looks like the conflict is between The hinted files are ttf's so I was too hasty before in suggesting the cause of the problem, sorry :). Not seeing a clearly best answer, anyone? |
There's not really any other option though. If someone wants the variable version they need to explicitly choose which one, as otherwise the different fonts would override eachother. F.ex. Theoretically it might be nice to just have It also seems like the multi-axis variable version doesn't work in all applications due to the metadata being wrong as well? rsms/inter#142 So |
I'm still of the opinion that the unhinted version should be the default, with the others being available in separate outputs, as that is the arrangement that will work for the mast usecases. |
I marked this as stale due to inactivity. → More info |
I marked this as stale due to inactivity. → More info |
Motivation for this change
https://github.com/rsms/inter/releases/tag/v3.12
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)