Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.docker-tools: Port to Python #80048

Merged
merged 1 commit into from
Feb 28, 2020
Merged

nixosTests.docker-tools: Port to Python #80048

merged 1 commit into from
Feb 28, 2020

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Feb 13, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc tfc mentioned this pull request Feb 13, 2020
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 13, 2020
@tfc
Copy link
Contributor Author

tfc commented Feb 13, 2020

@GrahamcOfBorg test docker-tools

@veprbl veprbl added the 6.topic: testing Tooling for automated testing of packages and modules label Feb 14, 2020
@worldofpeace
Copy link
Contributor

A new test case got added baa78de

@worldofpeace
Copy link
Contributor

cc @nlewo

@nlewo
Copy link
Member

nlewo commented Feb 15, 2020

@tfc I've rebased your commit onto master in nlewo@09112bc. So, you could just pick this commit and push force your branch to update this PR ;)
And thanks for this PR!

@tfc tfc force-pushed the port-docker-tools-test branch from c2709f6 to 6bb849d Compare February 15, 2020 15:22
@tfc
Copy link
Contributor Author

tfc commented Feb 15, 2020

@nlewo thank you! did so.

@worldofpeace i put the time string into a variable. does this fix your concern?

@tfc
Copy link
Contributor Author

tfc commented Feb 15, 2020

@GrahamcOfBorg test docker-tools

@tfc tfc force-pushed the port-docker-tools-test branch from 6bb849d to 0a49699 Compare February 27, 2020 16:16
@tfc
Copy link
Contributor Author

tfc commented Feb 27, 2020

@GrahamcOfBorg test docker-tools

nlewo
nlewo approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to merge it soon because one more test is arriving ;)

@worldofpeace worldofpeace merged commit 2e89e0d into NixOS:master Feb 28, 2020
@nlewo
Copy link
Member

nlewo commented Feb 28, 2020

Thanks!

@tfc tfc deleted the port-docker-tools-test branch February 28, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tfc @worldofpeace @nlewo @flokli @veprbl