-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixosTests.docker-preloader: Port to Python #80051
Conversation
@GrahamcOfBorg test docker-preloader |
@tfc Did this succeed on your machine? Seems to fail on ofborg:
|
@flokli weird. Yes, it works on both my machines. |
@GrahamcOfBorg test docker-preloader |
Fails on my machine
|
@tfc this also failed for me, when running
|
It finally fails on my systems, too. I wonder how/why it ever worked, as the commit that introduces this module maps the images RO: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/docker-preloader.nix#L92 However, i have no idea how to fix this without modifying the module (possible to the worse). @nlewo any idea? |
@tfc As this port is fairly trivial, can you rebase this PR to latest master, and mark it as broken? |
This currently fails with a "read-only file system" error.
1861162
to
33905f8
Compare
nvm, I did the rebase, and marked it as broken in a follow-up commit. |
Huh, I missed #93791. |
Motivation for this change
#72828
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)