Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.rsyslogd: Port to python #80096

Merged
merged 1 commit into from
Mar 2, 2020
Merged

nixosTests.rsyslogd: Port to python #80096

merged 1 commit into from
Mar 2, 2020

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Feb 14, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc tfc requested review from flokli and worldofpeace February 14, 2020 07:36
@tfc
Copy link
Contributor Author

tfc commented Feb 14, 2020

@GrahamcOfBorg test rsyslogd

@tfc tfc mentioned this pull request Feb 14, 2020
Closed
@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Feb 14, 2020
@veprbl veprbl added the 6.topic: testing Tooling for automated testing of packages and modules label Feb 14, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 14, 2020
@flokli flokli requested a review from aanderse February 18, 2020 17:03
@flokli
Copy link
Contributor

flokli commented Feb 18, 2020

cc @aanderse - it seems it's not properly added to all-tests.nix.

@aanderse
Copy link
Member

cc @aanderse - it seems it's not properly added to all-tests.nix.

@flokli reviewing my own PR history on this it seems I had added this test to the list of all tests. I'd have to dig to find out when it was removed, and by who.

@flokli
Copy link
Contributor

flokli commented Feb 22, 2020

@aanderse sorry, seems I was mistaken here - it does exist in current master, and has since the introduction of all-tests.nix at least.

@flokli
Copy link
Contributor

flokli commented Feb 22, 2020

From the look of it, handleTest seems to have a problem with files returning an attrset of tests. @infinisil, do you know what's going on here?

@tfc tfc force-pushed the port-rsyslogd-test branch from 45f302c to cb3b472 Compare February 27, 2020 16:00
@tfc
Copy link
Contributor Author

tfc commented Feb 27, 2020

@GrahamcOfBorg test rsyslogd

@flokli flokli merged commit d6587c0 into NixOS:master Mar 2, 2020
@flokli
Copy link
Contributor

flokli commented Mar 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tfc @flokli @aanderse @veprbl