Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVDI: 2019-01-16 -> 2019-02-25 #81012

Merged
merged 1 commit into from
Mar 9, 2020
Merged

EVDI: 2019-01-16 -> 2019-02-25 #81012

merged 1 commit into from
Mar 9, 2020

Conversation

sjau
Copy link

@sjau sjau commented Feb 25, 2020

Motivation for this change

Support for kernel 5.5, see DisplayLink/evdi#185 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Feb 25, 2020
@sjau
Copy link
Author

sjau commented Mar 3, 2020

@peterhoeg ping

peterhoeg
peterhoeg reviewed Mar 3, 2020
View reviewed changes
pkgs/os-specific/linux/evdi/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/evdi/default.nix Outdated Show resolved Hide resolved
@sjau sjau force-pushed the evdi-2020-02-25 branch from 33b040c to 473c805 Compare March 3, 2020 15:45
@sjau
Copy link
Author

sjau commented Mar 6, 2020

@peterhoeg ping

@sjau
Copy link
Author

sjau commented Mar 9, 2020

@peterhoeg need anything else?

@peterhoeg
Copy link
Member

Thanks!

@peterhoeg peterhoeg merged commit ddd7d25 into NixOS:master Mar 9, 2020
@sjau
Copy link
Author

sjau commented Mar 9, 2020

Thx for merging. I hope all the pings weren't too much :)

@sjau sjau deleted the evdi-2020-02-25 branch March 9, 2020 18:00
@peterhoeg
Copy link
Member

peterhoeg commented Mar 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjau @peterhoeg