Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exiv2: fix exiv2.pc file #81091

Merged
merged 1 commit into from
Feb 29, 2020
Merged

exiv2: fix exiv2.pc file #81091

merged 1 commit into from
Feb 29, 2020

Conversation

worldofpeace
Copy link
Contributor

This fix comes from #71669.

Motivation for this change

It was mentioned on #nixos @cole-h

Things done

The .pc file looks ok now.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from jtojnar February 26, 2020 04:28
@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 26, 2020
cole-h
cole-h approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this while trying to package qimgv; the build would fail (due to cmake failing) because of the malformed includedir in exiv2.pc. Using this patch, qimgv now successfully builds!

Thanks for the quick action!

@worldofpeace worldofpeace merged commit 04384d5 into NixOS:master Feb 29, 2020
@worldofpeace worldofpeace deleted the fix-exiv2-pc branch February 29, 2020 00:11
@worldofpeace
Copy link
Contributor Author

backported to 20.03 in ff41002

@jtojnar
Copy link
Member

jtojnar commented Mar 1, 2020

Could we also report this upstream? Projects should handle both absolute and relative paths in GNUInstallDirs flags. It will be ugly without https://gitlab.kitware.com/cmake/cmake/issues/19568

@jtojnar jtojnar removed the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 4, 2020
This was referenced Nov 2, 2021
Merged
Open
@nh2
Copy link
Contributor

nh2 commented Nov 2, 2021

Linking issue that collects such CMake path issues: #144170

@kotatsuyaki kotatsuyaki mentioned this pull request Jan 8, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@worldofpeace @jtojnar @nh2 @cole-h