Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluation of cabal2nix #83825

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Fix evaluation of cabal2nix #83825

merged 1 commit into from
Mar 31, 2020

Conversation

Gabriella439
Copy link
Contributor

cabal2nix fails to evaluate due to attempting to
evaluate pkgs.haskellPackages.hackage-db_2_1_0, which
does not exist. However, the default
pkgs.haskellPackages.hackage-db is already version 2.1.0,
so the fix is simple: go back to using the default version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gabriella439
Fix evaluation of cabal2nix
8d2c08e 
`cabal2nix` fails to evaluate due to attempting to
evaluate `pkgs.haskellPackages.hackage-db_2_1_0`, which
does not exist.  However, the default
`pkgs.haskellPackages.hackage-db` is already version 2.1.0,
so the fix is simple: go back to using the default version.
@ofborg ofborg bot added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 31, 2020
@jtojnar jtojnar merged commit e6674f6 into NixOS:master Mar 31, 2020
@jtojnar
Copy link
Member

jtojnar commented Mar 31, 2020

Thanks.

@Gabriella439 Gabriella439 deleted the gabriel/fix_cabal2nix branch March 31, 2020 10:23
@Gabriella439
Copy link
Contributor Author

@jtojnar: You're welcome! 🙂

@nh2 nh2 mentioned this pull request Mar 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriella439 @jtojnar