-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comedilib: init at 0.11.0 #84243
comedilib: init at 0.11.0 #84243
Conversation
0d2542a
to
7f19594
Compare
@GrahamcOfBorg eval |
7f19594
to
696cd99
Compare
696cd99
to
7ad4f55
Compare
From some reason @GrahamcOfBorg had issues with the attempt to split the outputs - hence all the force-pushes. I removed the |
7ad4f55
to
01513d9
Compare
Do you intend to use I noticed it's not contained in |
Not really... I just noticed that the build report of it searched for comedilib support and I suspect these is not done via Python but via the c headers. However, If I do this: diff --git i/pkgs/top-level/python-packages.nix w/pkgs/top-level/python-packages.nix
index 86339e361cb..efd362b7fc4 100644
--- i/pkgs/top-level/python-packages.nix
+++ w/pkgs/top-level/python-packages.nix
@@ -2005,6 +2005,8 @@ in {
constantly = callPackage ../development/python-modules/constantly { };
+ comedilib = toPythonModule pkgs.comedilib;
+
cornice = callPackage ../development/python-modules/cornice { };
cram = callPackage ../development/python-modules/cram { }; This works:
|
Should I do it? |
Nah, this was mostly a heads-up. I don't really know how |
Thanks for the PR! |
Motivation for this change
Optional dependency for GNUradio (see #82263 ).
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)