Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sniffglue: init at 0.10.1 #85340

Merged
merged 1 commit into from
Apr 18, 2020
Merged

sniffglue: init at 0.10.1 #85340

merged 1 commit into from
Apr 18, 2020

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 16, 2020

Motivation for this change

sniffglue is a network sniffer written in rust.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 16, 2020
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 18, 2020

Hi, @worldofpeace @marsam could you review this PR? Thank you very much!

worldofpeace
worldofpeace reviewed Apr 18, 2020
View reviewed changes
pkgs/tools/networking/sniffglue/default.nix Outdated
buildInputs = [ libpcap libseccomp ];

nativeBuildInputs = [ pkgconfig ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a style thing, but I usually order native first and then build

@worldofpeace
Copy link
Contributor

Does this program have to run as root to work?

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 18, 2020

@worldofpeace Yes, sniffglue is a packet sniffer and it need to run as root, just like tcpdump.

@worldofpeace worldofpeace merged commit 21861f3 into NixOS:master Apr 18, 2020
@worldofpeace
Copy link
Contributor

@xrelkd Thanks, merged this for you ✨

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 18, 2020

@worldofpeace, Thank you!!

@xrelkd xrelkd deleted the add/sniffglue branch April 18, 2020 18:18
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 20, 2020

Added a network sniffer for #81418 (cc @JoshuaFern)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrelkd @worldofpeace