gnomeExtensions.volume-mixer: bring it back and fix it #87481

bjornfor · 2020-05-10T10:44:53Z

Motivation for this change

Seems like a useful extension.

This reverts commit ee5506c.

Further:

Add it to the gnomeExtensions attrset. (The reason for removing it in
the first place was because it wasn't registered there.)
Move from .../volume-mixer.nix to .../volume-mixer/default.nix, to
align with the other extensions.
Update to latest version.
Fix the installPhase.
Comment that there is a Makefile for this package, but it requires
npm, so keep the buildPhase unchanged.
Add missing deps: pulseaudio and python3
Add a small patch to find pulseaudio.

Things done

aneeshusa · 2020-05-19T01:12:46Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+  meta = with stdenv.lib; {
+    description = "GNOME Shell Extension allowing separate configuration of PulseAudio devices";
+    license = licenses.gpl2;
+    maintainers = with maintainers; [ aneeshusa ];


I don't use this extension anymore so I wouldn't be a good reviewer/maintainer.

Me neither. Do you want to be removed fron the maintainers list?

I think that can interpreted that as a yes but it would be great to find someone that uses it to find bugs etc.

I added myself as maintainer. Not sure when I have the time to test this on master again though...

stale · 2020-11-17T11:36:31Z

I marked this as stale due to inactivity. → More info

SuperSandro2000 · 2020-11-23T20:20:20Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+  src = fetchFromGitHub {
+    owner = "aleho";
+    repo = "gnome-shell-volume-mixer";
+    rev = "${version}";


Suggested change

rev = "${version}";

rev = version;

SuperSandro2000 · 2020-11-23T20:21:48Z

Result of nixpkgs-review pr 87481 run on x86_64-linux 1

1 package built:

gnomeExtensions.volume-mixer

SuperSandro2000 · 2020-11-23T20:22:41Z

Can this file https://github.com/bjornfor/nixpkgs/blob/master/pkgs/desktops/gnome-3/extensions/volume-mixer.nix then be deleted?

bjornfor · 2020-11-23T21:58:52Z

Can this file https://github.com/bjornfor/nixpkgs/blob/master/pkgs/desktops/gnome-3/extensions/volume-mixer.nix then be deleted?

I don't see pkgs/desktops/gnome-3/extensions/volume-mixer.nix anywhere now.

bjornfor · 2020-11-23T22:01:14Z

I don't see pkgs/desktops/gnome-3/extensions/volume-mixer.nix anywhere now.

Oh, you literally meant the volume-mixer.nix file in my very old nixpkgs fork? You looked at the master branch, but that's not the branch this PR is against. Anyway, I updated the master branch in my fork just now.

This reverts commit ee5506c. Further: * Add it to the gnomeExtensions attrset. (The reason for removing it in the first place was because it wasn't registered there.) * Move from .../volume-mixer.nix to .../volume-mixer/default.nix, to align with the other extensions. * Update to latest version. * Fix the installPhase. * Comment that there is a Makefile for this package, but it requires npm, so keep the buildPhase unchanged. * Add missing deps: pulseaudio and python3 * Add a small patch to find pulseaudio. * Replace maintainer aneeshusa with bjornfor, as aneeshusa doesn't seem interested in this package anymore.

jtojnar · 2020-12-01T08:23:20Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+  ];
+
+  buildInputs = [
+    glib


If this is added for glib-compile-schemas, it should go to nativeBuildInputs, ideally with a comment.

jtojnar · 2020-12-01T08:24:01Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+    substituteInPlace ./shell-volume-mixer@derhofbauer.at/pautils/pa.py \
+        --subst-var-by pulseaudio ${pulseaudio}


You can use substituteAll directly in patches.

jtojnar · 2020-12-01T08:24:46Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+
+  buildInputs = [
+    glib
+    pulseaudio


Is this an actual build input or just needed for hardcoding the path?

jtojnar · 2020-12-01T08:27:07Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+        --subst-var-by pulseaudio ${pulseaudio}
+  '';
+
+  # Could use the Makefile, but it requires npm...


Ideally, we would ask upstream to make the dependency installation optional and allow using sassc from PATH.

jtojnar · 2020-12-01T08:27:21Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+  '';
+
+  installPhase = ''
+    mkdir -p $out/share/gnome-shell/extensions/${uuid}


When overriding installPhase, you should also provide runHook preInstall and runHook postInstall. Though, in this case, it is better to rely on the default installPhase.

jtojnar · 2020-12-01T08:27:50Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+  '';
+
+  installPhase = ''
+    mkdir -p $out/share/gnome-shell/extensions/${uuid}


It would be also nice to ask upstream to add a make install target.

jtojnar · 2020-12-01T08:28:19Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+
+  meta = with stdenv.lib; {
+    description = "GNOME Shell Extension allowing separate configuration of PulseAudio devices";
+    license = licenses.gpl2;


gpl2 is unclear, use gpl2Plus or gpl2Only. See https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 for more details.

jtojnar · 2020-12-01T08:29:02Z

pkgs/desktops/gnome-3/extensions/volume-mixer/default.nix

+    description = "GNOME Shell Extension allowing separate configuration of PulseAudio devices";
+    license = licenses.gpl2;
+    maintainers = with maintainers; [ bjornfor ];
+    homepage = https://github.com/aleho/gnome-shell-volume-mixer;


Unquoted URLs are deprecated: NixOS/rfcs#45

piegamesde · 2021-07-14T12:11:55Z

volume-mixer has been packaged in nixpkgs as of #118232. Unsurprisingly however, it does not work. I will have a look at a good way forward how to allow manual fixes for automatically packaged extensions.

piegamesde · 2021-09-10T22:22:27Z

Please have a look at #137131. Note that my proposed patch framework works on top of the already compiled extensions.gnome.org sources, thus some non-trivial adjustments may be required to the patch.

I'd appreciate if you tried to rebase this on top of my PR to test out the patch mechanism. But I can also give it a shot myself if you tell me which patches I need to apply (when ignoring the compilation setup).

bjornfor · 2021-09-11T06:48:32Z

@piegamesde : Nice! I don't have enough interest/time to work on this now unfortunately. But thanks a lot for your work on the gnome extensions. Much appreciated!

piegamesde · 2021-09-11T10:38:12Z

I'm going to close this then, hopefully the next motivated person will find this and start off from here. GNOME extensions that don't work out of the box need somebody who uses them, otherwise they'll rot really quickly.

bjornfor requested a review from aneeshusa May 10, 2020 10:45

ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 10, 2020

aneeshusa reviewed May 19, 2020

View reviewed changes

stale bot added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md and removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Nov 17, 2020

SuperSandro2000 requested changes Nov 23, 2020

View reviewed changes

bjornfor force-pushed the gnome-extension-volume-mixer branch 3 times, most recently from fff4019 to da8c501 Compare November 23, 2020 22:08

bjornfor added 2 commits November 23, 2020 23:09

gnomeExtensions.volume-mixer: 3.36.6 -> 3.38.0

7a090b8

bjornfor force-pushed the gnome-extension-volume-mixer branch from da8c501 to 7a090b8 Compare November 23, 2020 22:09

ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Nov 24, 2020

jtojnar reviewed Dec 1, 2020

View reviewed changes

SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021

piegamesde closed this Sep 11, 2021

bjornfor deleted the gnome-extension-volume-mixer branch November 5, 2022 15:20

bjornfor restored the gnome-extension-volume-mixer branch April 4, 2023 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gnomeExtensions.volume-mixer: bring it back and fix it #87481

gnomeExtensions.volume-mixer: bring it back and fix it #87481

bjornfor commented May 10, 2020

aneeshusa May 19, 2020

bjornfor May 21, 2020

SuperSandro2000 Nov 17, 2020

bjornfor Nov 23, 2020

stale bot commented Nov 17, 2020

SuperSandro2000 Nov 23, 2020

bjornfor Nov 23, 2020

SuperSandro2000 commented Nov 23, 2020

SuperSandro2000 commented Nov 23, 2020

bjornfor commented Nov 23, 2020

bjornfor commented Nov 23, 2020

jtojnar Dec 1, 2020

jtojnar Dec 1, 2020

jtojnar Dec 1, 2020

jtojnar Dec 1, 2020

jtojnar Dec 1, 2020

jtojnar Dec 1, 2020

jtojnar Dec 1, 2020

jtojnar Dec 1, 2020

piegamesde commented Jul 14, 2021

piegamesde commented Sep 10, 2021

bjornfor commented Sep 11, 2021

piegamesde commented Sep 11, 2021

		substituteInPlace ./shell-volume-mixer@derhofbauer.at/pautils/pa.py \
		--subst-var-by pulseaudio ${pulseaudio}

gnomeExtensions.volume-mixer: bring it back and fix it #87481

gnomeExtensions.volume-mixer: bring it back and fix it #87481

Conversation

bjornfor commented May 10, 2020

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Nov 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuperSandro2000 commented Nov 23, 2020

SuperSandro2000 commented Nov 23, 2020

bjornfor commented Nov 23, 2020

bjornfor commented Nov 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

piegamesde commented Jul 14, 2021

piegamesde commented Sep 10, 2021

bjornfor commented Sep 11, 2021

piegamesde commented Sep 11, 2021