Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo sha #8862

Closed
wants to merge 1 commit into from
Closed

Fix cargo sha #8862

wants to merge 1 commit into from

Conversation

globin
Copy link
Member

@globin globin commented Jul 16, 2015

fixes #8566

Review on Reviewable

@globin
Copy link
Member Author

globin commented Jul 16, 2015

cc @wizeman

@vcunat
Copy link
Member

vcunat commented Jul 18, 2015

My fetch is getting yet another hash 16f371jj89xplfc1fygvvhyhrq634v0w9674gz6j06m7blxqylpx. Do you know if leaveDotGit is needed? #8567.

@wizeman
Copy link
Member

wizeman commented Jul 21, 2015

@vcunat I just tried to build without leaveDotGit and it seems to build and work fine, apart from some error messages during the build due to the lack of a .git directory, and the lack of the git commit in the output of cargo --version.

Since the leaveDotGit is causing more problems than it solves, I think I will remove it instead of merging this PR to update the hash once again. I will close this PR later when I push the fix.

BTW, the leaveDotGit was introduced by @madjar, so maybe he can clarify if anything else could be broken.

@madjar
Copy link
Member

madjar commented Jul 21, 2015

It was package a long time ago, before cargo even had a its 0.1.0 release, so git was pretty much the only way to have a version. Since it now has stable releases, that's not needed anymore. We could even use the github tarball with the same effect.

@globin globin deleted the cargo-fix branch July 27, 2016 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo build yields a sha256 mismatch
4 participants