-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ardour: add ardour 6 and make it the default #88950
Conversation
looks like you've missed libpulse-dev and libwebsockes-dev packages as dependency |
@x42 seems that in order to build with libwebsockets, you also need libuv (assuming that's what provides uv.h), but it only fails halfway trough the build. |
I made an earlier PR here: #87274 - Please make sure you cherry-pick all of the changes from my PR that you want to include. I will close my PR in favor of this one afterward. Also it's always a good idea to check for other PRs, before starting your own, to avoid duplicate work. |
@magnetophon Forgot to push the updated commits? |
@veprbl Ah, yes, something went wrong. |
1d9c1b7
to
d936550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a few minor comments.
@veprbl Thanks, all done. |
We leave Ardour 5 in, since Ardour 6 has a new latency compensation algorithm, so your mixes might end up sounding different in the new version.
Something went wrong here, I'm trying to fix it! |
We leave Ardour 5 in, since Ardour 6 has a new latency compensation
algorithm, so your mixes might end up sounding different in the new version.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)