-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/corerad: add settings option to supersede configFile #89781
Conversation
@GrahamcOfBorg test corerad |
Config looks sane to me with go-toml's output:
I did just notice that #89744 uses the tool |
@GrahamcOfBorg test corerad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the nit below!
Signed-off-by: Matt Layher <mdlayher@gmail.com>
@GrahamcOfBorg test corerad |
Motivation for this change
Compliance with NixOS/rfcs#42 since @marsam added go-toml which made outputting TOML config trivial. I borrowed the pattern here from the Prometheus module:
nixpkgs/nixos/modules/services/monitoring/prometheus/default.nix
Lines 20 to 24 in 0e040d1
We also add a new test for HTTP metrics output and set up a monitoring interface which can't easily be tested, but does verify that the various config modes work.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)/cc @aanderse @jonringer @infinisil who discussed adding a settings option with me in my original PR: #77252