Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MythTV: 30.0 -> 31.0 #93486

Closed
wants to merge 1 commit into from
Closed

MythTV: 30.0 -> 31.0 #93486

wants to merge 1 commit into from

Conversation

LouisDK1
Copy link
Contributor

@LouisDK1 LouisDK1 commented Jul 19, 2020 •
edited
Loading

Motivation for this change

MythTV was upgraded to version 31.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from titanous July 19, 2020 21:12
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 19, 2020
@LouisDK1
Copy link
Contributor Author

I made a force-push. Maybe the new commit will build?

@dasj19
Copy link
Contributor

dasj19 commented Jul 20, 2020

I'll check this shortly and come back with the results

@dasj19
Copy link
Contributor

dasj19 commented Jul 20, 2020 •
edited
Loading

Ran nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93486"and got the following issues

error: while evaluating 'callPackageWith' at /home/daniel/.cache/nixpkgs-review/pr-93486/nixpkgs/lib/customisation.nix:117:35, called from /home/daniel/.cache/nixpkgs-review/pr-93486/nixpkgs/pkgs/top-level/all-packages.nix:21592:12:
while evaluating 'makeOverridable' at /home/daniel/.cache/nixpkgs-review/pr-93486/nixpkgs/lib/customisation.nix:67:24, called from /home/daniel/.cache/nixpkgs-review/pr-93486/nixpkgs/lib/customisation.nix:121:8:
anonymous function at /home/daniel/.cache/nixpkgs-review/pr-93486/nixpkgs/pkgs/applications/video/mythtv/default.nix:1:1 called without required argument 'libXNVCtrl', at /home/daniel/.cache/nixpkgs-review/pr-93486/nixpkgs/lib/customisation.nix:69:16

Check around the dependency 'libXNVCtrl' and see if it is needed.. then try to build locally with:
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

@LouisDK1
Copy link
Contributor Author

LouisDK1 commented Jul 20, 2020 •
edited
Loading

@dasj19. Thx. I forgot to remove some old dependencies. Should be fixed now.

@dasj19
Copy link
Contributor

dasj19 commented Jul 21, 2020 •
edited
Loading

@LouisDK1 I have tried again and it still doesnt build. I put libXNVCtrl back as dependency as it is required, but then the disable-os-detection.patch fails to apply.. I think that patch needs to be adjusted to the new code.

@LouisDK1 LouisDK1 force-pushed the mythtv310 branch 3 times, most recently from f1db667 to 9546bb4 Compare July 21, 2020 19:06
@LouisDK1
Copy link
Contributor Author

LouisDK1 commented Jul 21, 2020 •
edited
Loading

@dasj19 My last commit seems to be complete now and work. Was able to run nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93486" successfully.

dasj19
dasj19 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it runs successfully indeed.

@LouisDK1 LouisDK1 force-pushed the mythtv310 branch 2 times, most recently from afab6a4 to 4629e15 Compare July 29, 2020 22:06
@LouisDK1
Copy link
Contributor Author

@rycee Can you help me merge a new version of mythtv once again?

rycee pushed a commit that referenced this pull request Jul 30, 2020
@LouisDK1 @rycee
mythtv: 30.0 -> 31.0
6eadc11 
PR #93486
@rycee
Copy link
Member

rycee commented Jul 30, 2020

Thanks! Builds fine and the binaries seem to work. Rebased to master in 6eadc11.

@rycee rycee closed this Jul 30, 2020
@LouisDK1 LouisDK1 deleted the mythtv310 branch July 30, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 approved these changes

@titanous titanous Awaiting requested review from titanous

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LouisDK1 @dasj19 @rycee