Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom: Fix #92487 #93621

Merged
merged 1 commit into from
Aug 2, 2020
Merged

atom: Fix #92487 #93621

merged 1 commit into from
Aug 2, 2020

Conversation

worldofpeace
Copy link
Contributor

We rewrote the expression to use phases from genericBuilder.
#92487 (comment)

Motivation for this change

Fix #92487

Things done

I unset XDG_DATA_DIRS in a shell and could still open the file selection dialog.
I also inspected that the wrapper had the correct entries.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
atom: Fix NixOS#92487
35cb34c 
We rewrote the expression to use phases from genericBuilder.
NixOS#92487 (comment)
@worldofpeace worldofpeace requested a review from jtojnar July 22, 2020 04:15
@ofborg ofborg bot requested review from NeQuissimus, offlinehacker and ysndr July 22, 2020 04:54
@worldofpeace worldofpeace merged commit 3d80450 into NixOS:master Aug 2, 2020
@worldofpeace worldofpeace deleted the fix-atom branch August 2, 2020 00:39
@worldofpeace
Copy link
Contributor Author

backported in 7dc4385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@ysndr ysndr Awaiting requested review from ysndr

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atom crashes when opening the "select file" modal
1 participant
@worldofpeace