lf: 14 -> 15

[yoctocell]

Motivation for this change

Update to newest release
https://github.com/gokcehan/lf/releases/tag/r15

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[danieldk]

Result of nixpkgs-review pr 93895 1

1 package built:

- lf

Binary works as expected.

BTW. not sure if this is worthwhile reporting upstream, but lf will segfault when /etc/passwd is not readable (e.g. in a sandbox):

$ wrapit `realpath results/lf/bin/lf`
2020/07/26 09:30:24 user: user: lookup userid 1000: no such file or directory
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x57ad2a]

goroutine 1 [running]:
main.init.3()
	/build/source/os.go:72 +0x7da

[primeos]

@danieldk it's probably a very rare edge case but why not? Will you submit a report or should I take care of it?

From the code it looks like it would make sense to change this part. Especially the handling of err != nil (a few lines above) seems wrong (resulting in the segmentation fault). IMO it would be better to actually fallback to $HOME and $USER or just exit cleanly (we could also submit a PR).

[danieldk]

@danieldk it's probably a very rare edge case but why not? Will you submit a report or should I take care of it?

Turns out there already was an issue about that gokcehan/lf#191, so I added a comment to that.